Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Flask document URLs in docstring #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2020
Merged

Update Flask document URLs in docstring #4551

merged 2 commits into from
Aug 26, 2020

Conversation

seratch
Copy link
Contributor

@seratch seratch commented Aug 26, 2020

Description

This pull request fixes outdated links (they are no longer available) of Flask documents. If I should create an issue, let me know.

Checklist

@seratch seratch requested review from ace-n and a team as code owners August 26, 2020 08:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 26, 2020
busunkim96
busunkim96 approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @seratch!

ace-n
ace-n approved these changes Aug 26, 2020
View reviewed changes
Copy link

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label Aug 26, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@ace-n ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 26, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 26, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 78d1c54 into GoogleCloudPlatform:master Aug 26, 2020
@seratch seratch deleted the patch-1 branch August 26, 2020 23:04
seratch added a commit to seratch/python-docs-samples that referenced this pull request Aug 28, 2020
@seratch
Update Flask document URLs in docstring (in addition to GoogleCloudPl…
e4d6b60 
…atform#4551)

GoogleCloudPlatform#4551 was not complete.
@seratch seratch mentioned this pull request Aug 28, 2020
Merged
8 tasks
engelke added a commit that referenced this pull request Aug 31, 2020
@seratch @engelke
Update Flask document URLs in docstring (in addition to #4551) (#4592)
9b13a6f 
#4551 was not complete.

Co-authored-by: Charles Engelke <[email protected]>
Co-authored-by: Ace Nassri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@leahecole leahecole

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seratch @ace-n @busunkim96 @leahecole @kokoro-team