Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor fixtures, add static resources #4599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 25, 2020
Merged

refactor fixtures, add static resources #4599

merged 7 commits into from
Sep 25, 2020

Conversation

leahecole
Copy link
Collaborator

@leahecole leahecole requested a review from a team as a code owner August 28, 2020 18:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2020
ghost
ghost reviewed Aug 28, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! It looks great to me, just one comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 29, 2020
@leahecole
Copy link
Collaborator Author

@ericschmidtatwork PTAL again and request more changes or approve if it's ready :)

dinagraves
dinagraves approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@dinagraves dinagraves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - I should re-do the Cloud Run samples using this pattern!

memorystore/redis/cloud_run_deployment/e2e_test.py


@pytest.fixture
def service_url_auth_token(deployed_service):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way you separated out each part of the "services" into their own fixtures!

ghost
ghost approved these changes Sep 16, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@leahecole leahecole added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 25, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2020
@tmatsuo tmatsuo mentioned this pull request Sep 25, 2020
Closed
@leahecole leahecole merged commit 664e035 into master Sep 25, 2020
@leahecole leahecole deleted the split_memorystore_fixtures branch September 25, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinagraves dinagraves dinagraves approved these changes

Assignees

@dinagraves dinagraves

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leahecole @dinagraves @kokoro-team