dataflow/run_template: slightly increase max retry time in test #4692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4686 It should be an uncommon occurrence that a job hangs in queue for more than 4 minutes, probably because many tests were triggered at a similar time. I'm slightly increasing the max retry time to 5 minutes to leave more room for jobs to be cancelled, but most of the time it will be cancelled much quicker.
tmatsuo
approved these changes
Sep 16, 2020
kurtisvg
approved these changes
Sep 16, 2020
busunkim96
reviewed
Sep 16, 2020
Co-authored-by: Bu Sun Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4686
It should be an uncommon occurrence that a job hangs in queue for more than 4 minutes (and therefore unable to cancel), probably because many tests were triggered at a similar time.
I'm slightly increasing the max retry time to 5 minutes to leave more room for jobs to be cancelled, but most of the time it will be cancelled much quicker.
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)