feat: init eventarc quickstarts #4710

grant · 2020-09-18T19:59:27Z

Description

Moves alpha run/events-* samples to beta eventarc/*.
Updates markdown instructions to use gcloud beta commands.
Creates new eventarc/ folder. Updates GH owners.
Updates run/ README.md
No source code changes.

Fixes #4708

Checklist

I have followed Sample Guidelines from AUTHORING_GUIDE.MD
README is updated to include all relevant information
Tests pass: nox -s py-3.6 (see Test Environment Setup)
Lint pass: nox -s lint (see Test Environment Setup)
These samples need a new API enabled in testing projects to pass (let us know which ones)
- cloudeventarc
These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
Please merge this PR for me once it is approved.
This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample

CC: @llatif

Signed-off-by: Grant Timmerman <[email protected]>

eventarc/pubsub/README.md

averikitsch · 2020-09-18T22:32:59Z

eventarc/audit-storage/README.md

+
+```sh
+MY_RUN_SERVICE=gcs-service
+MY_RUN_CONTAINER=gcs-container


nit: you may want to note that this needs to be globally unique

averikitsch · 2020-09-18T22:34:34Z

eventarc/README.md

+
+    Learn more about [testing your container image locally.][testing]
+
+## Deploying


nit:

Suggested change

## Deploying

## Deploying a Cloud Run service

Do you want to add any trigger creation info in this readme?

Changed to Run service like mentioned above.

Mentioned generic step for creating trigger. It depends on the trigger type.

averikitsch · 2020-09-18T22:35:21Z

eventarc/README.md

+[run_deploy]: https://cloud.google.com/run/docs/deploying
+[events_pubsub]: events-pubsub/
+[anthos_events_pubsub]: events-pubsub/anthos.md
+[events_storage]: events-storage/


audit-storage?

Good catch.

I tested all 4 links in VS Code. I had to add README.md for the default READMEs to work.

averikitsch · 2020-09-18T22:35:52Z

eventarc/README.md

+## Samples
+
+|           Sample                |        Description       |     Deploy    |
+| ------------------------------- | ------------------------ | ------------- |


No cloud run button?

Not a big fan of the button as you can't modify samples or easily test. Could be a FR

averikitsch · 2020-09-18T22:36:44Z

Do region tags need to be updated?

Signed-off-by: Grant Timmerman <[email protected]>

grant

Addressed comments.

grant · 2020-09-18T22:45:49Z

eventarc/README.md

+## Samples
+
+|           Sample                |        Description       |     Deploy    |
+| ------------------------------- | ------------------------ | ------------- |


Not a big fan of the button as you can't modify samples or easily test. Could be a FR

grant · 2020-09-18T22:50:32Z

eventarc/README.md

+
+    Learn more about [testing your container image locally.][testing]
+
+## Deploying


Changed to Run service like mentioned above.

Mentioned generic step for creating trigger. It depends on the trigger type.

grant · 2020-09-18T22:53:32Z

eventarc/README.md

+[run_deploy]: https://cloud.google.com/run/docs/deploying
+[events_pubsub]: events-pubsub/
+[anthos_events_pubsub]: events-pubsub/anthos.md
+[events_storage]: events-storage/


Good catch.

I tested all 4 links in VS Code. I had to add README.md for the default READMEs to work.

grant · 2020-09-18T22:54:45Z

eventarc/audit-storage/README.md

+
+```sh
+MY_RUN_SERVICE=gcs-service
+MY_RUN_CONTAINER=gcs-container


eventarc/pubsub/README.md

grant · 2020-09-21T22:23:01Z

Hi @GoogleCloudPlatform/python-samples-owners, can you review this PR? It looks like I must have a 2nd review.

grant · 2020-09-24T16:10:11Z

@busunkim96 @tmatsuo Can you review? Not sure how best to request a review.

grant · 2020-09-25T14:26:47Z

Hey folks, can we get a review in today? Trying to get the samples ready for our TW.

grant added 2 commits September 18, 2020 14:42

feat: init eventarc quickstarts

aaeb741

Signed-off-by: Grant Timmerman <[email protected]>

fix: update readmes and gh owners

a740a66

Signed-off-by: Grant Timmerman <[email protected]>

grant requested a review from averikitsch September 18, 2020 19:59

grant requested a review from a team as a code owner September 18, 2020 19:59

grant self-assigned this Sep 18, 2020

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2020

fix: fix gcs cal assertion

879d5c2

Signed-off-by: Grant Timmerman <[email protected]>

averikitsch approved these changes Sep 18, 2020

View reviewed changes

fix: readme nits

da2ee43

Signed-off-by: Grant Timmerman <[email protected]>

grant commented Sep 18, 2020

View reviewed changes

product-auto-label bot added the samples Issues that are directly related to samples. label Sep 19, 2020

Merge branch 'master' into grant_eventarc_init

c1e05f4

Merge branch 'master' into grant_eventarc_init

7aa32f8

busunkim96 approved these changes Sep 25, 2020

View reviewed changes

docs: update eventarc readme formatting

6047a0f

grant merged commit b7c80d4 into GoogleCloudPlatform:master Sep 25, 2020

grant deleted the grant_eventarc_init branch September 25, 2020 15:47


		Learn more about [testing your container image locally.][testing]

		## Deploying

feat: init eventarc quickstarts #4710

feat: init eventarc quickstarts #4710

Uh oh!

Conversation

grant commented Sep 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

averikitsch commented Sep 18, 2020

Uh oh!

grant left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

grant commented Sep 21, 2020

Uh oh!

grant commented Sep 24, 2020

Uh oh!

grant commented Sep 25, 2020

Uh oh!

Uh oh!

grant commented Sep 18, 2020 •

edited

Loading