Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Scipy example #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 24, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions appengine/flexible/scipy/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
assets/resized_google_logo.jpg
4 changes: 4 additions & 0 deletions appengine/flexible/scipy/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# SciPy on App Engine Flexible

This sample demonstrates how to use SciPy to resize an image on App Engine Flexible.

6 changes: 6 additions & 0 deletions appengine/flexible/scipy/app.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
runtime: python
vm: true
entrypoint: gunicorn -b :$PORT main:app

runtime_config:
python_version: 3
Binary file added appengine/flexible/scipy/assets/google_logo.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
52 changes: 52 additions & 0 deletions appengine/flexible/scipy/main.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# Copyright 2016 Google Inc. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import logging
import os

from flask import Flask
import scipy.misc

app = Flask(__name__)


# [START scipy]
@app.route('/')
def resize():
"""Demonstrates using scipy to resize an image."""
app_path = os.path.dirname(os.path.realpath(__file__))
image_path = os.path.join(app_path, 'assets/google_logo.jpg')
img = scipy.misc.imread(image_path)
img_tinted = scipy.misc.imresize(img, (300, 300))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps img_resized instead? Also, update the comment in line 34

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been merged and Bill's at burning man, man. Send a PR if you feel strongly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just catching up on email 😅

output_image_path = os.path.join(
app_path, 'assets/resized_google_logo.jpg')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably unnecessary to have the resized file checked in, since that's what you're generating..

# Write the tinted image back to disk
scipy.misc.imsave(output_image_path, img_tinted)
return "Image resized."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not return the image itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should really be serving static images from the filesystem like that and I'd rather keep it simple than demonstrate a bad practice. I'm more inclined to actually upload to a bucket but it just seems like overkill considering the only point is to say "hey, scipy will work if you add it to the requirements.txt"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, but I'd still like the user to see the result. It's one more line of code, why not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯_(ツ)_/¯

# [END scipy]


@app.errorhandler(500)
def server_error(e):
logging.exception('An error occurred during a request.')
return """
An internal error occurred: <pre>{}</pre>
See logs for full stacktrace.
""".format(e), 500


if __name__ == '__main__':
# This is used when running locally. Gunicorn is used to run the
# application on Google App Engine. See entrypoint in app.yaml.
app.run(host='127.0.0.1', port=8080, debug=True)
35 changes: 35 additions & 0 deletions appengine/flexible/scipy/main_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# Copyright 2016 Google Inc. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import filecmp
import os

import main


def test_index():
main.app.testing = True
client = main.app.test_client()
test_path = os.path.dirname(os.path.realpath(__file__))
asset_path = os.path.join(
test_path, 'assets/resized_google_logo.jpg')
fixtured_path = os.path.join(
test_path, 'fixtures/assets/resized_google_logo.jpg')
try:
os.remove(asset_path)
except OSError:
pass # if doesn't exist
r = client.get('/')
assert filecmp.cmp(asset_path, fixtured_path)
assert r.status_code == 200
4 changes: 4 additions & 0 deletions appengine/flexible/scipy/requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Flask==0.11.1
gunicorn==19.6.0
scipy==0.18.0
Pillow==3.3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Is Pillow necessary? I assume it's just a dependency of scipy, since I don't see it imported itself?

1 change: 1 addition & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ requests==2.11.1
requests[security]==2.11.1
responses==0.5.1
rsa==3.4.2
scipy==0.18.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you do nox -s reqrollup?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not but I just did and there's no changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just wanted to verify.

sendgrid==3.2.10
simplejson==3.8.2
six==1.10.0
Expand Down