Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(iam): fix a broken test #4790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2020
Merged

fix(iam): fix a broken test #4790

merged 2 commits into from
Oct 2, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Oct 2, 2020 •
edited
Loading

fixes #4770

I think it's sufficient to check if there's a newline.

fix(iam): fix a broken test
8302cf5 
fixes GoogleCloudPlatform#4770

I think the permissions changed their names.
apigee -> apigateway
@tmatsuo tmatsuo requested review from melaniedejong and a team as code owners October 2, 2020 21:28
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
melaniedejong
melaniedejong reviewed Oct 2, 2020
View reviewed changes
@tmatsuo tmatsuo added the automerge Merge the pull request once unit tests and other checks pass. label Oct 2, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit d072ac3 into GoogleCloudPlatform:master Oct 2, 2020
@tmatsuo tmatsuo deleted the fix-iam branch October 2, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@melaniedejong melaniedejong melaniedejong approved these changes

Assignees

@leahecole leahecole

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iam.api-client.custom_roles_test: test_query_testable_permissions failed
4 participants
@tmatsuo @busunkim96 @melaniedejong @leahecole