Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ace-n
Copy link

@ace-n ace-n commented Nov 11, 2020

Please merge for me once this is approved. Thanks!

Related CL: cl/350677556

@ace-n ace-n requested a review from busunkim96 November 11, 2020 23:36
@ace-n ace-n requested a review from a team as a code owner November 11, 2020 23:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2020
@ace-n
Copy link
Author

ace-n commented Nov 11, 2020

Unrelated note: it looks like we're running the periodic builds for all Python versions.

Maybe we should reconsider that, since those builds tend to take awhile + consume lots of CI resources? 🤔

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 16, 2020
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once other comments are addressed.

@ace-n
Copy link
Author

ace-n commented Jan 8, 2021

FYI looks like the failures were caused by a flaky Cloud Trace test? 🤔

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 8, 2021

FYI, kokoro configs submitted in g3. To be honest, I still expect failures on py-3.9 builds, likely because some APIs need to be enabled.

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 9, 2021

FYI, I see lots of nox > Sessions not found: py-3.9 in the py-3.9 builds.

@ace-n
Copy link
Author

ace-n commented Jan 9, 2021

I updated the numpy version in composer/workflows (a failed attempt to reduce deprecation warning spam).

@leahecole @rafalbiegacz can one of you confirm that this is OK, or if I should revert?

@ace-n
Copy link
Author

ace-n commented Jan 9, 2021

Failures in 3.9 build seem unrelated.

Python folks - please merge this for me if you think it's good to go. Thanks!

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 11, 2021

Python 3.9 build still has failing tests. Some are expected (need to enable APIs), some are unexpected.
I'll take a look at the build log and try to fix the build.

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 11, 2021

  • appengine/flexible/memcache

Failing to compile pylibmc, saying fatal error: libmemcached/memcached.h: No such file or directory.

Update: Maybe I can install libmemcached-dev.
Update: Also amusingly this test is skipped on current build now:

main_test.py::test_index SKIPPED (Memcache is unavailable.) 

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 11, 2021

  • appengine/standard/*

Probably we should skip them in py-3.9 build. Currently it says:

nox > Error while collecting sessions.
nox > Sessions not found: py-3.9

I think we need to update appengine/standard/noxfile-template.py to fix this.

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 11, 2021

  • appengine/standard_python3/cloud_debugger

It seems like pip could not find google-python-cloud-debugger package:

nox > python -m pip install -r requirements.txt
nox > Command python -m pip install -r requirements.txt failed with exit code 1:
ERROR: Could not find a version that satisfies the requirement google-python-cloud-debugger==2.15
ERROR: No matching distribution found for google-python-cloud-debugger==2.15

Update: Probably we can skip this test for now, related: GoogleCloudPlatform/cloud-debug-python#22

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 11, 2021

  • composer/workflows
    Failing to install scipy

Update: Maybe I can try installing liblapack-dev and libblas-dev.
Update: Then it failed to compile numpy. Maybe I should try the latest version of scipy. There might be wheel package available.
Update: It still failed to compile numpy, I decided to skip the py-3.9 build for now.

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 15, 2021

py-3.6 build has a failure which is likely unrelated to this change. I filed #5247 and restarted the build.

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 16, 2021

Another failure. Filed #5248 restarting the build.

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 16, 2021

Another flake:
#5249

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 16, 2021

All green. Merging.

@tmatsuo tmatsuo merged commit a16413e into master Jan 16, 2021
@tmatsuo tmatsuo deleted the ace-n-patch-1 branch January 16, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants