bug fix - flaky bot issue #8431 #8482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes 1. Fix `test_list_namespace`: Update the check to do validation based on namespace object's name attribute. This change is required to due a bug in class's __eq__ method & flaky bot issue. 2. Update `namespace` method, to ensure that proper clean-up of created object. As of now, in case of failure, we found un wanted object created but did not clean-up
m-strzelczyk
approved these changes
Nov 10, 2022
Mariatta
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes
Fix
test_list_namespace: Update the check to do validation based on namespace object's name attribute. This change is required to due a bug in the class's eq method & flaky bot issue.Update
namespacemethod, to ensure that proper cleanup of created test objects. As of now, in case of failure, we found the unwanted object created but did not cleanup.Description
Fixes #8431
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)