chore(run/jobs): add retries for flaky Cloud Builds #8491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2022 11:43
|
Would |
davidcavazos
approved these changes
Nov 10, 2022
dandhlee
reviewed
Nov 10, 2022
run/jobs/e2e_test.py
Outdated
| built = True | ||
| except Exception as e: | ||
| print(e) | ||
|
|
There was a problem hiding this comment.
Are there any cleanups that needs to be done, possibly in a finally clause?
run/jobs/e2e_test.py
Outdated
| ] | ||
| ) | ||
| destroyed = False | ||
| for x in range(3): |
There was a problem hiding this comment.
Same 3 concerns as above! (backoff, exception, and cleanup using finally)
There was a problem hiding this comment.
This step looks like the clean-up step for the previous one.
In any case - is a finally clause required if we're working with backoff?
There was a problem hiding this comment.
It's a bit tricky in this case actually - I'm not sure what would be the best approach if teardown were to throw errors. In other cases I'd suggest finally to clean up but fine to leave it as is here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8465