chore(samples): remove flaky test conditions #8968
Conversation
The query expansion search result on the backend is not stable and the returned results may change over time. Tried to remove the strong ranking checks, and only check if query expansion is enabled in the search response.
|
This is to put a similar fix submitted under python-retail repo: |
|
Thanks for submitting! A couple of questions because I have no experience with this API - Does the expanded query check also validate that there are results at all? Is there also a way to check that the results are from the call we made and not an earlier call? (like a timestamp or something less flaky?) |
Thanks for reviewing! The API calls are stateless and transactional so the results won't be from previous calls. And we're trying to test from the response whether query expansion flow is triggered when we enable it in the API request. As for the returned products in the search result, due to some system flaws they don't always return the consistent results, which may cause the tests to be flaky in some cases. So I feel it's better not to check the matched result for this test case. |
The query expansion search result on the backend is not stable and the returned results may change over time. Tried to remove the strong ranking checks, and only check if query expansion is enabled in the search response. Co-authored-by: Karl Weinmeister <[email protected]>
The query expansion search result on the backend is not stable and the returned results may change over time. Tried to remove the strong ranking checks, and only check if query expansion is enabled in the search response.
Fixes #8798
Description
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)