Move dep for react-dom - #592
Merged
Merged
Conversation
itsmichaeldiego
approved these changes
May 31, 2018
Contributor
Author
|
thanks @itsmichaeldiego 👍 |
Contributor
Author
|
@itsmichaeldiego any chance we can get this one released? |
|
@itsmichaeldiego hey, can we have this change soon. |
Member
|
@jooj123 @prasadhewage Sorry guys, I am in holidays in Greece and I haven't been that active. I released this on v1.0.4 Cheers! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-domshould be apeerDepand not adependancyConsumers should be deciding if they want to include this as part of their bundle not the library