Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pass map instance to onDrag handler - #656

Merged
itsmichaeldiego merged 1 commit into
GoogleMapReact:masterfrom
bogomya:map-api-changes
Nov 8, 2018
Merged

Pass map instance to onDrag handler#656
itsmichaeldiego merged 1 commit into
GoogleMapReact:masterfrom
bogomya:map-api-changes

Conversation

@bogomya

@bogomya bogomya commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

Goal:
Add possibility to work with google map api in the onDrag handler.

  • documentation improving

@itsmichaeldiego

itsmichaeldiego commented Oct 16, 2018

Copy link
Copy Markdown
Member

@bogomya Could you explain how this improves and provide an example? Just for documentation, I totally understand what you are doing

@bogomya

bogomya commented Oct 16, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The idea was in getting map bounds on drag event to load new markers. I could use onChange, but onChange is called also when zoom event is occurred, and also on initial load.

@itsmichaeldiego

itsmichaeldiego commented Oct 24, 2018

Copy link
Copy Markdown
Member

@bogomya Thank you so much! This would be helpful. Could you provide a live example of this working? I need to check its working before releasing it.

itsmichaeldiego
itsmichaeldiego approved these changes Nov 2, 2018
View reviewed changes

@itsmichaeldiego itsmichaeldiego left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to see the example

@itsmichaeldiego
itsmichaeldiego merged commit 4a92a42 into GoogleMapReact:master Nov 8, 2018
itsmichaeldiego added a commit that referenced this pull request Nov 8, 2018
@itsmichaeldiego
Bump version to 1.1.0
31fb87d 
This includes: 

- #655 -> Add math abs to avoid negative values when calculating zoom 
- #656 -> Pass map instance to onDrag handler 
- #593 -> Added feature: update heat map on data change + fix linting
@itsmichaeldiego itsmichaeldiego mentioned this pull request Nov 8, 2018
Merged
itsmichaeldiego added a commit that referenced this pull request Nov 8, 2018
@itsmichaeldiego
Bump version to 1.1.0 (#671)
1603e3a 
This includes: 

- #655 Add math abs to avoid negative values when calculating zoom 
- #656 Pass map instance to onDrag handler 
- #593 Added feature: update heat map on data change + fix linting
@itsmichaeldiego

itsmichaeldiego commented Nov 8, 2018

Copy link
Copy Markdown
Member

@bogomya Merged and deployed in version 1.1.0, please try it and let me know

DonovanDeSmedt added a commit to DonovanDeSmedt/google-map-react that referenced this pull request Nov 21, 2018
@DonovanDeSmedt
Merge branch 'master' of github.com:google-map-react/google-map-react
ad9e522 
* 'master' of github.com:google-map-react/google-map-react:
  Bump to 1.1.1 (GoogleMapReact#680)
  Revert "Added feature: update heat map on data change + fix linting" (GoogleMapReact#679)
  Bump version to 1.1.0 (GoogleMapReact#671)
  Added feature: update heat map on data change + fix linting (GoogleMapReact#593)
  Pass map instance to onDrag handler (GoogleMapReact#656)
  add math abs to avoid negative values when calculating zoom (GoogleMapReact#655)
  Bump version to 1.0.9 (GoogleMapReact#651)
  Custom div style options (GoogleMapReact#634)
  Bump version to 1.0.8 (GoogleMapReact#646)
  Revert 643 fix/map context (GoogleMapReact#645)
  Bump version to 1.0.7 (GoogleMapReact#644)
  Add passive scroll (GoogleMapReact#631)
  Use React 16 portal to render map overlay (GoogleMapReact#643)
  Fix old examples links and add one to new examples (GoogleMapReact#633)
  Bump version to 1.0.6 (GoogleMapReact#621)
  Add prop `onTilesLoaded` (GoogleMapReact#615)
  Fix typo, and call fromContainerPixelToLatLng() as you would expect. (GoogleMapReact#620)
  Update API.md (GoogleMapReact#611)
  Upgrade version to 1.0.5 (GoogleMapReact#607)
  Remove marker jiggle. (GoogleMapReact#603)
@lock

lock Bot commented Dec 1, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@itsmichaeldiego itsmichaeldiego itsmichaeldiego approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bogomya @itsmichaeldiego