WIP: Upgrade to JS modules, TypeScript and LitElement #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why this branch has not been merged yet (almost 2 years and every check seems ok)? Ok, I understand that some properties has changed, but, by upgrading the major version, it should not break every projects that use it. Do you need something special before merging it? I don't want to fork it because I think it could be useful for a lot of people to have a typescript/litelement version of this web-component |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just starting the work, PR to track for now.
I'm changing the API a bit, trying to make it simpler and closer to the Maps API:
info→infoWindow,version→apiVersion, etc)clear()which removed the Maps marker object, but not the<google-map-marker>DOM nodes. Just remove the nodes instead.I'm thinking about removing
<google-map-point>and using a path property on<google-map-poly>instead.<google-map-poly>should probably be replaced with<google-map-polyline>,<google-map-polygon>,<google-map-rectangle>,<google-map-circle>, etc.