Conversation
Summary of ChangesHello @jsjgdh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request lays the groundwork for a comprehensive guide system within the editor. It establishes the necessary backend infrastructure for handling guide data and messages, integrates these capabilities into the editor's core message dispatching, and provides the initial frontend components for user interaction, such as dragging guides from rulers and toggling their visibility. This is the first of three planned PRs to fully implement guides. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the backend and frontend infrastructure for guides, including creating, moving, deleting, and displaying them. The changes are well-structured and the implementation is solid. I've provided a few suggestions to improve code quality by reducing duplication and decoupling components.
editor/src/messages/portfolio/document/guide_message_handler.rs
Outdated
Show resolved
Hide resolved
… getViewportElement, fix GuideMessage import
PR-1 out of 3.
contains: Core guide infrastructure + overlays + frontend ruler drag