Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Staticauth #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Staticauth #216

wants to merge 3 commits into from

Conversation

pvanassen
Copy link
Contributor

Fixed issue: #214

@FabianTerhorst
Copy link
Collaborator

👍

@Aphoh
Copy link
Collaborator

Aphoh commented Jul 25, 2016

@pvanassen This is good but REFRESH_TOKEN_MAP is a confusing name. You don't need the type in the name. Something like OAUTH_REFRESH_TOKENS would be much easier to understand.

@pvanassen
Copy link
Contributor Author

pvanassen commented Jul 26, 2016 •
edited
Loading

I don't see why, the name is clear. Feel free to change it after merge.

@FabianTerhorst
Copy link
Collaborator

I would stay with REFRESH_TOKENS.

@pvanassen
Copy link
Contributor Author

This bug is also fixed by #234

@pvanassen pvanassen closed this Jul 26, 2016
@pvanassen pvanassen deleted the staticauth branch July 30, 2016 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvanassen @FabianTerhorst @Aphoh