Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rewrote and Refactored login logic.Credential Providers transparently handle token refreshing for both Ptc and Google providers #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2016
Merged

Rewrote and Refactored login logic.Credential Providers transparently handle token refreshing for both Ptc and Google providers #234

merged 1 commit into from
Jul 26, 2016

Conversation

rajulbhatnagar
Copy link
Contributor

Changes made:

  • Transparent token handling by the credential provider. Request handler does not need to keep track of authinfo
  • Token refresh for Google and Ptc logins
  • All the API's should work. A single line change to login code required.
  • Proper exception handling

@rajulbhatnagar
Rewrote and Refactored login logic. Now the credential providers tran…
3413809 
…sparently handle providing credentials and refreshing tokens.
@pvanassen pvanassen mentioned this pull request Jul 26, 2016
Closed
@FabianTerhorst
Copy link
Collaborator

nice refactoring.

@Grover-c13
Copy link
Owner

Tested and checkStyled?

@jabbink
Copy link
Collaborator

jabbink commented Jul 26, 2016

Will test it now

@jabbink jabbink merged commit 3413809 into Grover-c13:Development Jul 26, 2016
jabbink added a commit that referenced this pull request Jul 26, 2016
@jabbink
Merge pull request #234
819d02d
@pvanassen pvanassen mentioned this pull request Jul 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajulbhatnagar @FabianTerhorst @Grover-c13 @jabbink