[DON'T MERGE] Initial Rxjava Async [WIP] #357
Conversation
commit 2b05b26 Author: Angelo Rüggeberg <[email protected]> Date: Sat Jul 30 07:43:07 2016 +0200 Added Util class to get Name for Pokedex Numbers, Also added Translations (#284) * Added Util class to get NAme for Pokedex Numbers, Also added Translations for those * Adjusted Files According to Pullrequest Review * Removed Double License Headeer, Added Missing License Header commit 65c8819 Author: Mustafa Ashurex <[email protected]> Date: Fri Jul 29 22:40:47 2016 -0700 Cleaned up some doc blocks (#352)
|
So awesome. GG @mashurex. |
|
There's a lot more RxJava work that can be done to make it really hum. I didn't subscribe on any particular schedulers or anything and it can be used to manage the cache- which it's currently not. It's a very initial and naive implementation at this point. |
|
In my opinion using rxjava for the async work is almost the best way. It should be totally ok to add rxjava to the project. |
| @@ -26,34 +26,19 @@ | |||
| import com.pokegoapi.main.RequestHandler; | |||
| import com.pokegoapi.util.SystemTimeImpl; | |||
| import com.pokegoapi.util.Time; | |||
| import lombok.Getter; | |||
| import lombok.Setter; | |||
There was a problem hiding this comment.
Why you remove lombok from this file?
There was a problem hiding this comment.
@FabianTerhorst my IDE probably auto-removed it because I HAD made all the get/set synchronized. As I look at them now it seems that I lose them in one of my changes and need to add synchronized back in.
|
some of the added docs has a different number of spaces, is checkstyle working? |
| @@ -529,7 +529,7 @@ private void getEdgesInChildrenCells(S2Point a, S2Point b, List<S2CellId> cover, | |||
| } | |||
| } | |||
|
|
|||
| /* | |||
| /** | |||
There was a problem hiding this comment.
should be against checkstyle?
There was a problem hiding this comment.
I ran everything against check style, spaces look the same but I added an extra * to make it a docblock comment
|
pokenames is already merged in dev branch, why is it still in this pr? |
|
I'll clean it up, I think I screwed up my tracking to keep this up to date with Development at the same time. |
Changes made:
InvalidProtoBuffererrors occurPlayerProfileandInventoriesclasses to utilize the new Observablessynchronizedmethods to PokemonGO, PlayerProfile, and Inventories classes for thread safety