Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: implement PayrollHistory component with enhanced date formatting and i18n #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 19, 2025
Merged

feat: implement PayrollHistory component with enhanced date formatting and i18n #578

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
941924f
feat: implement PayrollHistory componetnt with enhanced date formatti…
jeffredodd Sep 18, 2025
f96ba95
fix: update PayrollHistory namespace to match TypeScript constraints
jeffredodd Sep 18, 2025
7caf247
fix: restore proper PayrollHistory namespace casing
jeffredodd Sep 18, 2025
f1ad370
fix: pr feedback
jeffredodd Sep 18, 2025
0f8c399
fix: build fix
jeffredodd Sep 18, 2025
be70ea6
fix: updating loc file
jeffredodd Sep 18, 2025
cd83151
fix: loc issue
jeffredodd Sep 18, 2025
fc27613
fix: wrap cancel mutation in base submit
jeffredodd Sep 18, 2025
3b1243e
fix: update translations and get things fixed
jeffredodd Sep 18, 2025
01ee409
Merge branch 'main' into jdj/payroll-history-api-connection
jeffredodd Sep 18, 2025
0657ee4
fix: prfeedback
jeffredodd Sep 18, 2025
48c1354
fix: pr feedback
jeffredodd Sep 19, 2025
a042858
Merge branch 'main' into jdj/payroll-history-api-connection
serikjensen Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 15 additions & 26 deletions src/components/Company/DocumentSigner/DocumentList/ManageSignatories.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { render, screen } from '@testing-library/react'
import { screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { describe, test, expect, vi, beforeEach } from 'vitest'
import { ManageSignatories } from './ManageSignatories'
import { useDocumentList } from './useDocumentList'
import { GustoTestProvider } from '@/test/GustoTestApiProvider'
import { renderWithProviders } from '@/test-utils/renderWithProviders'
vi.mock('./useDocumentList')

Expand Down Expand Up @@ -35,9 +34,9 @@ describe('ManageSignatories', () => {

renderWithProviders(<ManageSignatories />)

expect(screen.getByRole('heading')).toHaveTextContent('otherSignatoryTitle')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes to our translation provider and now these keys render as a by product.

expect(screen.getByRole('paragraph')).toHaveTextContent('noSignatorySubtext')
expect(screen.getByRole('button')).toHaveTextContent('assignSignatoryCta')
expect(screen.getByRole('heading')).toHaveTextContent('Only the signatory can sign documents.')
expect(screen.getByRole('paragraph')).toHaveTextContent('A signatory has not yet been assigned')
expect(screen.getByRole('button')).toHaveTextContent('Assign signatory')
})

test('when user is the signatory', () => {
Expand All @@ -52,15 +51,13 @@ describe('ManageSignatories', () => {
},
})

render(
<GustoTestProvider>
<ManageSignatories />
</GustoTestProvider>,
)
renderWithProviders(<ManageSignatories />)

expect(screen.getByRole('heading')).toHaveTextContent('selfSignatoryTitle')
expect(screen.getByRole('paragraph')).toHaveTextContent('selfSignatorySubtext')
expect(screen.getByRole('button')).toHaveTextContent('changeSignatoryCta')
expect(screen.getByRole('heading')).toHaveTextContent(
'Please note, only the signatory can sign documents.',
)
expect(screen.getByRole('paragraph')).toHaveTextContent('You are the assigned signatory.')
expect(screen.getByRole('button')).toHaveTextContent('Change signatory')
})

test('when another user is the signatory', () => {
Expand All @@ -75,15 +72,11 @@ describe('ManageSignatories', () => {
},
})

render(
<GustoTestProvider>
<ManageSignatories />
</GustoTestProvider>,
)
renderWithProviders(<ManageSignatories />)

expect(screen.getByRole('heading')).toHaveTextContent('otherSignatoryTitle')
expect(screen.getByRole('paragraph')).toHaveTextContent('otherSignatorySubtext')
expect(screen.getByRole('button')).toHaveTextContent('changeSignatoryCta')
expect(screen.getByRole('heading')).toHaveTextContent('Only the signatory can sign documents.')
expect(screen.getByRole('paragraph')).toHaveTextContent('Your signatory is Jane Smith, CEO.')
expect(screen.getByRole('button')).toHaveTextContent('Change signatory')
})

test('handles change signatory button click', async () => {
Expand All @@ -92,11 +85,7 @@ describe('ManageSignatories', () => {
handleChangeSignatory: mockHandleChangeSignatory,
})

render(
<GustoTestProvider>
<ManageSignatories />
</GustoTestProvider>,
)
renderWithProviders(<ManageSignatories />)

await userEvent.click(screen.getByRole('button'))
expect(mockHandleChangeSignatory).toHaveBeenCalledTimes(1)
Expand Down
4 changes: 2 additions & 2 deletions src/components/Payroll/PayrollHistory/PayrollHistory.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { action } from '@ladle/react'
import { PayrollHistoryPresentation } from './PayrollHistoryPresentation'
import type { PayrollHistoryItem } from './PayrollHistoryPresentation'
import type { PayrollHistoryItem } from './PayrollHistory'

export default {
title: 'Domain/Payroll/PayrollHistory',
Expand All @@ -26,7 +26,7 @@ const mockPayrollHistory: PayrollHistoryItem[] = [
{
id: '3',
payPeriod: 'Aug 27 – Sep 10, 2025',
type: 'Dismissal',
type: 'External',
payDate: 'Nov 24, 2024',
status: 'Complete',
amount: 30842.99,
Expand Down
Loading