Added ImageJPEG #30
Added ImageJPEG #30
Conversation
| for( size_t i = 0; i < NB_BYTES; ++i ) | ||
| v.push_back(i); | ||
| imageJPEG.setData( v ); | ||
| } |
|
+1 otherwise |
| const std::string expectedJSONWithData = "{\n" | ||
| " \"data\" : [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9," | ||
| " 10, 11, 12, 13, 14, 15 ]\n" | ||
| "}\n"; |
There was a problem hiding this comment.
the .fbs should use byte for data, which will cause the data to be emitted base64-encoded, not as array-of-uint8_t.
There was a problem hiding this comment.
Not sure if I understand, you want to rename 'data' into 'byte'? It's only an attribute name, how can this impact the generated code?
There was a problem hiding this comment.
No, the type of data should be byte.
There was a problem hiding this comment.
Sorry, still don't get it, I changed data from ubyte to byte, but what I get is an array-of-int8_t instead of array-of-uint8_t. I do not see how base64 can be emitted there :-(
There was a problem hiding this comment.
It works in the test: https://github.com/HBPVIS/ZeroBuf/blob/master/tests/jsonSerialization.cpp#L120
Not sure what's going wrong for you, but maybe you can find it following the test?
There was a problem hiding this comment.
OK, now I understand, the code for the base64 generation is not in my branch, that's why it did not make any sense to me. Let me see what I can do.
b02f164 to
fa2a641
Compare
|
Jenkins was red - don't merge then. Please fix asap, I now have activated the branch protection on this repo. |
|
Yep, just realised. Working on it. |
No description provided.