Remove set/getString method for non-string dynamic members #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not sure I got the cleanup intention right. Only needed for 'real' strings imo, hence removed for all other array/vector types. |
|
To me this change makes sense. I wonder if we could go one step further and remove everything except the string getters for the string type. Are the typedef vector, etc.. needed? |
Contributor
Author
|
Not needed also it seems. The zerobuf::Vector is needed in theory for guaranteeing zero-copy. |
Contributor
|
Agreed on the zero-copy path. Not sure how it looks for the equivalent of set( T*, size )? |
Contributor
Author
|
Ahhh, that merge went too fast. Had the ones @rdumusc suggested not pushed yet... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.