Add ConstAllocator and static functions create(), ZEROBUF_TYPE_NAME(), ZEROBUF_TYPE_IDENTIFIER() #59
Conversation
zerobuf/ConstAllocator.h
Outdated
| ConstAllocator& operator = ( const ConstAllocator& ) = delete; | ||
|
|
||
| uint8_t* getData() final | ||
| { return const_cast< uint8_t* >( _data ); } // internal |
There was a problem hiding this comment.
Be aware that this is not sufficient to protect the internal buffer. If the allocator is used through it's base class this function is not private. I'm not sure making it throw prevents non const access, without reading all the client code is difficult to say if the compiler is going to pick always the const version.
There was a problem hiding this comment.
I had the throw before for the same reasons, but it does not work unfortunately. With the test schema in the unit tests, it passes by code which calls getData() and the compiler prefers the non-const over the const version, hence it passes by here. A delete for this non-const getData() is what one wants here...
|
Besides what we discussed offline about getData and the cosmetic changes about strings +1. |
…, ZEROBUF_TYPE_IDENTIFIER() This is part of event-based communication spec from HBPVIS/ZeroEQ#152.
This is part of event-based communication spec from HBPVIS/ZeroEQ#152.