Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@eile
Copy link
Contributor

@eile eile commented Jan 25, 2017

No description provided.

@eile
Copy link
Contributor Author

eile commented Jan 25, 2017

screen shot 2017-01-25 at 12 08 26

@rdumusc
Copy link

rdumusc commented Jan 25, 2017

+1, pretty-format is better! You need to adapt the unit tests as well + add changelog entry.

@eile
Copy link
Contributor Author

eile commented Jan 26, 2017

Working on the test already, but something weird is going on there (see below). I did not think Changelog necessary?

/Users/eilemann/Software/stable/ZeroBuf/tests/jsonSerialization.cpp:277: error: in "json_schema_empty": check test::TestEmpty::ZEROBUF_SCHEMA() == R"({
    "$schema": "http://json-schema.org/schema#",
    "title": "TestEmpty",
    "description": "Class TestEmpty of namespace ['test']",
    "type": "object",
    "additionalProperties": false
})" has failed [{
    "$schema": "http://json-schema.org/schema#",
    "title": "TestEmpty",
    "description": "Class TestEmpty of namespace ['test']",
    "type": "object",
    "additionalProperties": false
} != {
    "$schema": "http://json-schema.org/schema#",
    "title": "TestEmpty",
    "description": "Class TestEmpty of namespace ['test']",
    "type": "object",
    "additionalProperties": false
}]```

@rdumusc
Copy link

rdumusc commented Jan 26, 2017

As you wish ;-) I don't know what is the criteria for a necessary Changelog entry, but I also see no reason to omit it: the behavior is modified, and it is nice to have an up-to-date a document listing the progress happening in the project. I don't know about the string comparison issue, they look identical from what you posted.

@eile
Copy link
Contributor Author

eile commented Jan 26, 2017

Found the string thing. The JSON dump created trailing whitespace.

@eile eile force-pushed the master branch 2 times, most recently from 9d5c449 to d7ba411 Compare January 26, 2017 10:59
@eile eile merged commit d3d4015 into HBPVIS:master Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants