Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bilgili
Copy link
Contributor

@bilgili bilgili commented Apr 7, 2016

No description provided.

@dnachbaur
Copy link
Contributor

Changelog update and version bump missing. +1 otherwise.
Merge should be done once release is out and downstream projects are ready as well.

@dnachbaur
Copy link
Contributor

Hold on, not complete yet:

  1. zeq::Publisher::getURI() and zeq::http::Server::getURI() must return zeq::URI as well (see todo)
  2. zeq::URI( const servus::URI& ) needs to be explicit (see todo)
  3. zeq/uri.cpp:28 has TODO to be resolved

@bilgili
Copy link
Contributor Author

bilgili commented Apr 11, 2016

So, additionally all "todos" have to be resolved for this topic.

@dnachbaur
Copy link
Contributor

The mentioned todos are part of this topic, yes. Not sure if it's all todos in the project.

BOOST_CHECK_EQUAL( hostPort.getScheme(), "tcp" );
}

BOOST_AUTO_TEST_CASE(custom_schema_not_supported_yet)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that test is still valid imo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// TODO: only for compatibility for hbp schemas, remove after downstreams
// are fixed
I removed this to do from uri.cpp. What is in mind for this then ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema is left untouched, so actually only line 46 changes. The testname is then custom_schema. For the zeq::URI this is supported then, but not yet for the publisher/subscriber. Will do later then when needed. inproc could be interesting to have 'local' GUI only for instance.

@dnachbaur dnachbaur merged commit b5c27ca into HBPVIS:master Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants