Event as a servus::Serializable #145

bilgili · 2016-04-13T13:11:02Z

It is not complete yet but has the idea. I am still debugging. FYI @eile.

bilgili · 2016-04-14T09:24:47Z

zeq/event.cpp

+servus::Serializable::Data Event::_toBinary() const
+{
+    servus::Serializable::Data data;
+    data.ptr.reset( _impl->getData(), []( const void* ){});


The servus::Data class uses a shared_ptr which is not really used correctly ( all uses are deleting the deleter which is at the end a raw ptr - check ZeroBuf class _toBinary function as well ).

eile · 2016-04-14T09:55:32Z

tests/connection/broker.cpp

+        zeq::Event echoEvent( ::zeq::vocabulary::EVENT_ECHO,
+                              std::bind( &Subscriber::onEchoEvent,
+                                         this,
+                                         std::placeholders::_1 ));


use lambda?

bilgili · 2016-04-18T13:22:24Z

@eile : Are we renaming the zeroeq::Event ?

eile · 2016-04-18T14:52:43Z

tests/connection/broker.cpp

-                                                       *_publisher ));
-        BOOST_CHECK( subscriber.registerHandler( zeroeq::vocabulary::EVENT_ECHO,
-           std::bind( &Subscriber::onEchoEvent, this, std::placeholders::_1 )));
+        zeroeq::Subscriber subscriber( test::buildURI( "127.0.0.1", *_publisher ));


Same as for your code: Please adhere to 80c/line

The difference is, I would not complain :)

eile · 2016-04-18T15:13:24Z

Are we renaming the zeroeq::Event ?

Probably. Best I could come up would be zeroeq::FlatBuffer. FB should also become an optional dependency.

bilgili · 2016-04-18T20:07:05Z

I would keep the Event name and move to FBEvent ?

bilgili · 2016-04-20T11:52:22Z

"FB should also become an optional dependency."

Can you please open this a bit ? There are many places that refers to FB in the code ( CMake uses, C++ uses ). We want the FB related part as a separate library ?

eile · 2016-04-20T14:10:43Z

I would keep the Event name and move to FBEvent ?

I won't argue, but at this point it is an object (serializable) not an event anymore. Events will come back eventually, I had a first discussion with @chevtche last week but we are far from "done" on this feature.

eile · 2016-04-20T14:12:05Z

optional dependency

I was thinking 'common_find_package(FlatBuffers)' and if/ifdef ZEROEQ_USE_FLATBUFFERS in the appropriate places (probably just the CMakeLists to include the event class if fb available).

bilgili · 2016-04-20T15:32:54Z

Then, for instance Monsteer is depending on ZeroEq, which means in CMake of Monsteer, FLATBUFFERS_FOUND is used ? Or, still there is a way to use ZEROEQ_FLATBUFFERS variables over the place ?

eile · 2016-04-20T18:57:49Z

On 20. Apr 2016, at 17:32, Ahmet Bilgili [email protected] wrote:

Then, for instance Monsteer is depending on ZeroEq, which means in CMake of Monsteer, FLATBUFFERS_FOUND is used ? Or, still there is a way to use ZEROEQ_FLATBUFFERS variables over the place ?

Monsteer has (and will still need) a "common_find_package(FlatBuffers REQUIRED)”, so no need for conditionals.

Cheers,

Stefan.

hernando · 2016-04-25T09:27:56Z

tests/broker.h

+void onExitEvent( const zeroeq::FBEvent& event )
 {
-    BOOST_CHECK_EQUAL( event.getType(), zeroeq::vocabulary::EVENT_EXIT );
+    BOOST_CHECK_EQUAL( event.getType(), zeroeq::vocabulary::EVENT_ECHO );


Why renamed?

EXIT event is removed

@chevtche closed #153 without merging. On the other hand, if it's removed, then you have to remove the function.

Which function ?

I got it :)

hernando · 2016-04-25T09:37:32Z

Maybe I'm wrong because I'm late to this discussion, but to me it seems that implementing #152 and then adapting the FB code to use the new API will require less work and produce a better result than adapting the FB to use Serializable. The only thing I'm not sure is whether the current Subscriber::registerHandler would conflict with the proposal from #152.

bilgili · 2016-04-25T09:59:36Z

I started earlier with the idea and I have already moved everything in Monsteer towards it. So, lets merge these first and then lets see if we still need #152.

hernando · 2016-04-25T10:43:21Z

#152 will still be needed.

bilgili · 2016-04-25T11:23:07Z

If we have a empty serializable event made of "type" I am not sure you need it. I believe we have cleaned the subscriber & publisher API for this reason.

hernando · 2016-04-25T11:27:35Z

I'm not sure I understand what you mean.

bilgili · 2016-04-25T11:30:46Z

retest this please

bilgili · 2016-04-25T14:42:07Z

retest this please

bilgili · 2016-04-25T15:41:32Z

@eile: ping, I will commit Monsteer after this is merged.

eile · 2016-05-13T13:55:03Z

doc/Changelog.md


+* [145](https://github.com/HBPVIS/ZeroEQ/pull/145):
+  * The zeroeq::Event class is renamed to zeroeq::FBEvent
+  * zeroeq::FBEvent is derived from the servus::Serializable


eile · 2016-05-17T15:05:40Z

zeroeq/detail/fbevent.h

        parser.builder_.Clear();
+        // Since we are working on the same copy with new servus::Serializable
+        // based Flat Buffer events ( not memory per event ),
+        // we are copying the memory


rdumusc · 2016-05-18T11:44:20Z

zeroeq/subscriber.cpp

-                zmq_msg_close( &msg );
-            }
-        }
+       zmq_msg_t msg;


the whole block has been shifted, now it has 3 spaces

rdumusc · 2016-05-18T12:31:47Z

I'm giving a +1 since this has already been extensively reviewed, but I don't understand every details.

bilgili reviewed Apr 14, 2016
View reviewed changes

bilgili assigned eile Apr 14, 2016

eile reviewed Apr 14, 2016
View reviewed changes

eile reviewed Apr 18, 2016
View reviewed changes

hernando reviewed Apr 25, 2016
View reviewed changes

eile reviewed May 13, 2016
View reviewed changes

zero::Events are derived from servus::Serializable

4fba770

Ahmet Bilgili added 9 commits May 17, 2016 11:07

Remove unnecessary RestBridge classes and fixes according to comments

015fbcc

Rename Event to FBEvent

f031532

Remove EXIT event

b6db036

Removed applications based on old messages

725505f

Added JSON serialization utility functions

e367094

Flatbuffers is an optional dependency

f9b9baf

Memory is copied when event receives the data

18f1db7

Added an empty FB event for tests

b55aded

Updated change log

70021a1

eile reviewed May 17, 2016
View reviewed changes

bilgili assigned rdumusc and unassigned eile May 18, 2016

rdumusc reviewed May 18, 2016
View reviewed changes

zeroeq/subscriber.cpp Outdated

zmq_msg_close( &msg );

}

}

zmq_msg_t msg;

Copy link

rdumusc May 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole block has been shifted, now it has 3 spaces

Fixes according to comments

9da9514

bilgili merged commit 6de9a8a into HBPVIS:master May 18, 2016

Event as a servus::Serializable #145

Event as a servus::Serializable #145

Uh oh!

Conversation

bilgili commented Apr 13, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bilgili commented Apr 18, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eile commented Apr 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bilgili commented Apr 18, 2016

Uh oh!

bilgili commented Apr 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eile commented Apr 20, 2016

Uh oh!

eile commented Apr 20, 2016

Uh oh!

bilgili commented Apr 20, 2016

Uh oh!

eile commented Apr 20, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hernando commented Apr 25, 2016

Uh oh!

bilgili commented Apr 25, 2016

Uh oh!

hernando commented Apr 25, 2016

Uh oh!

bilgili commented Apr 25, 2016

Uh oh!

hernando commented Apr 25, 2016

Uh oh!

bilgili commented Apr 25, 2016

Uh oh!

bilgili commented Apr 25, 2016

Uh oh!

bilgili commented Apr 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rdumusc commented May 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eile commented Apr 18, 2016 •

edited

Loading

bilgili commented Apr 20, 2016 •

edited

Loading

bilgili commented Apr 25, 2016 •

edited

Loading