Clarify changed semantics of http::server::getSocketDescriptor() #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favreau
approved these changes
Nov 15, 2016
rdumusc
reviewed
Nov 15, 2016
doc/Changelog.md
Outdated
|
|
||
| * [185](https://github.com/HBPVIS/ZeroEQ/pull/185): | ||
| http::server::getSocketDescriptor() notifies on write after | ||
| [#184](https://github.com/HBPVIS/ZeroEQ/pull/184). |
Contributor
Author
There was a problem hiding this comment.
no, just putting a link to the pull request that introduced the change of semantics. Or what do you mean?
There was a problem hiding this comment.
oh ok sorry, I misread it as a duplicate of the previous line
zeroeq/http/server.h
Outdated
| * Can be used by client code to be notified when new data is available and | ||
| * subsequently call receive. | ||
| * subsequently call receive. Due to implementation details, the socket | ||
| * notifies on write. |
There was a problem hiding this comment.
I would have emphasized more:
notifies on write, not on read.
rdumusc
approved these changes
Nov 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.