Support custom HTTP URL endpoint for handled Serializables, expose hyphenated URLs for CamelCase event names #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdumusc
reviewed
Dec 9, 2016
rdumusc
left a comment
There was a problem hiding this comment.
+1, I prefer having the second parameter as you did instead of a bunch more overloads.
zeroeq/http/server.h
Outdated
| * Handle PUT and GET for the given object. | ||
| * | ||
| * @param object the object to update and serve on receive() | ||
| * @param event uses this as the URL endpoint instead of the default |
There was a problem hiding this comment.
should be 'use', not 'uses'. I also don't find 'event' very clear, but I don't know have a good suggestion. maybe 'address' or something like 'httpPath'?
eile
requested changes
Dec 12, 2016
zeroeq/http/server.cpp
Outdated
|
|
||
| bool handlePUT( servus::Serializable& serializable ) | ||
| bool handlePUT( servus::Serializable& serializable, | ||
| const std::string& event ) |
zeroeq/http/server.cpp
Outdated
| serializable.getSchema(), func ); | ||
| } | ||
|
|
||
| bool handleGET( std::string event, const std::string& schema, |
zeroeq/http/server.h
Outdated
| */ | ||
| ZEROEQHTTP_API bool handlePUT( servus::Serializable& object ); | ||
| ZEROEQHTTP_API bool handlePUT( servus::Serializable& object, | ||
| const std::string& event = std::string( )); |
Contributor
There was a problem hiding this comment.
overloads with (endpoint, object)
Contributor
Author
|
Updated |
eile
requested changes
Dec 12, 2016
zeroeq/http/server.h
Outdated
| * servus::Serializable::getTypeName() | ||
| */ | ||
| ZEROEQHTTP_API bool handleGET( const std::string& endpoint, | ||
| servus::Serializable& object ); |
…phenated URLs for CamelCase event names
eile
approved these changes
Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
I wasn't sure of creating (another!) overload for handle/handlePUT/handleGET with the customizable event name or what I did now with the default parameter to not break the API. Let me know what you prefer.