Cleanup type declarations to be symmetric with other function definitions. #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
rdumusc
approved these changes
May 10, 2017
rdumusc
left a comment
There was a problem hiding this comment.
I thought we had discussed this and decided to keep the 4 function typedefs in server.h because that's the only place where they apply. There are no other http types and no benefits in separating the typedefs from the server IMO. But if you insist ;-)
|
|
||
| #pragma once | ||
|
|
||
| #include <zeroeq/types.h> |
Contributor
Author
There was a problem hiding this comment.
Is used, at least for some basic types like uint128_t
Contributor
Author
|
Yes, we had discussed:
Imo the only alternative would be making this sub-types of the class, which is done in other places. |
c7321c1 to
e659a76
Compare
Contributor
Author
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.