Zeroconf announce for http::Server #208
Conversation
ab9064e to
c9cf1da
Compare
zeroeq/http/server.cpp
Outdated
| result.getString())); | ||
| } | ||
|
|
||
| if (uri_.getHost() != uri.getHost() || uri_.getPort() == 0) |
There was a problem hiding this comment.
this should be printed independently of the servus stuff
There was a problem hiding this comment.
It is, unless Zeroconf announcement fails in which case the ctor throws anyways.
There was a problem hiding this comment.
Correction, it isn't. Fixing.
zeroeq/http/server.cpp
Outdated
| const std::string JSON_TYPE = "application/json"; | ||
| const std::string REQUEST_REGISTRY = "registry"; | ||
| const std::string REQUEST_SCHEMA = "schema"; | ||
| const std::string HTTP_SERVER_SERVICE = "_http._tcp"; |
There was a problem hiding this comment.
_zeroeqhttp._tcp? otherwise it looks very generic.
There was a problem hiding this comment.
Also, add some documentation in the header of the class that this features exists.
There was a problem hiding this comment.
I on purpose used the generic service for HTTP servers.
There was a problem hiding this comment.
Ah ok. Then mention it for future reference :)
6416fa5 to
347ffc4
Compare
|
+1 for me. @hernando also should a have look |
hernando
left a comment
There was a problem hiding this comment.
Explain a bit more the motivation in the commit message.
| if (!result) | ||
| { | ||
| ZEROEQTHROW(std::runtime_error("Zeroconf announce failed: " + | ||
| result.getString())); |
There was a problem hiding this comment.
Do you really want to throw if the announcement fails?
There was a problem hiding this comment.
Since this is C&P from the Publisher, I guess so?
Currently used by the viztools.Local() python module, but generally of interest for REST clients to find our apps.
Done |
No description provided.