http Server: fix handling of CORS preflight requests #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnachbaur
approved these changes
May 24, 2017
zeroeq/http/requestHandler.h
Outdated
| // HTTP headers for CORS responses | ||
| enum class CorsResponseHeader | ||
| { | ||
| ACCESS_CONTROL_ALLOW_HEADERS, |
Contributor
There was a problem hiding this comment.
lower-case and not prefix as this is an enum class?
Author
There was a problem hiding this comment.
there is no prefix, the header is this long ("Access-Control-Allow-Headers"). You're probably right about lower-case, although personally I still find upper-case more readable... since enum class Header in response.h also use upper case that makes it consistent.. but I can change it, no problem ;-)
dnachbaur
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.