Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature/statuses #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
noahk004 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Feature/statuses #291

noahk004 wants to merge 8 commits into from

Conversation

@noahk004
Copy link
Member

@noahk004 noahk004 commented Oct 10, 2025

This PR resolves #244.

  • Modified /apps/site/src/app/portal
  • Added new status checks according to Figma
  • Moved confirmation component to a a new page /confirmation

github-actions[bot]
github-actions bot reviewed Oct 10, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

prettier

[prettier] reported by reviewdog 🐶

zothacks-site/apps/site/src/app/portal/components/StatusIndicator.module.scss

Line 12 in afdcbb1

background-color: rgba(theme.$light-green, 0.69);

[prettier] reported by reviewdog 🐶

zothacks-site/apps/site/src/app/portal/components/StatusIndicator.module.scss

Lines 16 to 25 in afdcbb1

border: 5px solid theme.$dark-green;
border-radius: 30px;
padding: 30px 40px;
width: 100%;
box-sizing: border-box;
display: flex;
align-items: center;
justify-content: space-between;
font-size: 1.3rem;
color: theme.$off-white;

[prettier] reported by reviewdog 🐶

zothacks-site/apps/site/src/app/portal/components/StatusIndicator.module.scss

Lines 27 to 30 in afdcbb1

p {
margin: 0;
}
}

[prettier] reported by reviewdog 🐶

zothacks-site/apps/site/src/app/portal/components/StatusIndicator.tsx

Line 10 in afdcbb1

export default function StatusIndicator({ icon, dark, children }: StatusIndicatorProps) {

[prettier] reported by reviewdog 🐶

zothacks-site/apps/site/src/app/portal/components/StatusIndicator.tsx

Line 12 in afdcbb1

<div className={styles.indicator + " " + (dark ? styles.dark : styles.light)}>

[prettier] reported by reviewdog 🐶

zothacks-site/apps/site/src/app/portal/components/StatusIndicator.tsx

Line 17 in afdcbb1

}

[prettier] reported by reviewdog 🐶

zothacks-site/apps/site/src/app/portal/components/Timeline.module.scss

Lines 4 to 6 in afdcbb1

display: flex;
flex-direction: column;
gap: 16px;

[prettier] reported by reviewdog 🐶

zothacks-site/apps/site/src/app/portal/components/Timeline.module.scss

Lines 8 to 12 in afdcbb1

h2 {
font-size: 2.5rem;
color: theme.$white;
}
}

[prettier] reported by reviewdog 🐶

zothacks-site/apps/site/src/app/portal/components/Timeline.tsx

Line 1 in afdcbb1

import { Status, Decision, ReviewStatus, PostAcceptedStatus } from "@/lib/userRecord";

[prettier] reported by reviewdog 🐶

zothacks-site/apps/site/src/app/portal/components/Timeline.tsx

Line 11 in afdcbb1

status: Status;

[prettier] reported by reviewdog 🐶

zothacks-site/apps/site/src/app/portal/components/Timeline.tsx

Lines 15 to 38 in afdcbb1

return (
<div className={styles.statusWrapper}>
{(Object.values(Decision).includes(status as Decision) || status === Status.Signed || status === Status.Confirmed) && (
<StatusIndicator icon={check} dark={true}>Application Submitted</StatusIndicator>
)}
{(status === Status.Accepted || status === Status.Signed || status === Status.Confirmed) && (<>
<StatusIndicator icon={check} dark={true}>Application Accepted</StatusIndicator>
<StatusIndicator icon={dots} dark={status === Status.Signed || status === Status.Confirmed}>Waiver Signed</StatusIndicator>
<StatusIndicator icon={dots} dark={status === Status.Confirmed}>Attendance Confirmed</StatusIndicator>
</>)}
{status === Status.Waitlisted && (
<StatusIndicator icon={dots} dark={true}>Waitlisted</StatusIndicator>
)}
{status === Status.Rejected && (
<StatusIndicator icon={x} dark={true}>Application Rejected</StatusIndicator>
)}
</div>
);
}

@github-actions
Copy link

github-actions bot commented Oct 10, 2025 •
edited
Loading

Deploy preview for zothacks-site-2023 ready!

Name Hack at UCI Site
Preview Visit Preview
Commit 32eb5b0

noahk004 and others added 3 commits October 9, 2025 19:12
@noahk004 @github-actions
Update apps/site/src/app/confirmation/page.tsx
7a1f30c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@noahk004
Prettier changes
563b4e7
@noahk004
Merge branch 'feature/statuses' of https://github.com/HackAtUCI/zotha…
88287ee 
…cks-site into feature/statuses

Resolve minor formatting differences between branches
@NoNathan17
Copy link
Contributor

NoNathan17 commented Oct 12, 2025

For the Signed and Confirmed statuses. The status boxes look a bit more compressed.
Screenshot 2025-10-12 at 12 17 13 PM

Other than that and running prettier, I think this PR should be ready to merged.

IanWearsHat
IanWearsHat requested changes Oct 15, 2025
View reviewed changes
Copy link
Member

@IanWearsHat IanWearsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Noah, I have a few comments on the frontend.

@noahk004 noahk004 requested a review from IanWearsHat October 21, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@IanWearsHat IanWearsHat Awaiting requested review from IanWearsHat

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Portal] Statuses

4 participants

@noahk004 @NoNathan17 @IanWearsHat