Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Moved week 7,8,9 from the JavaScript repo to this repository (So JavaScript3). #1

Merged
merged 7 commits into from
Mar 19, 2018

Conversation

mkruijt
Copy link
Member

@mkruijt mkruijt commented Mar 13, 2018

No description provided.

@mkruijt mkruijt requested a review from a team March 13, 2018 13:28
Copy link
Member

@GeorgeSapkin GeorgeSapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the links.

|1.|• [Object Oriented Programming and Classes](fundamentals/oop_classes.md)<br>• [The `this` keyword](fundamentals/this.md) |[Reading Week 7](/Week1/README.md)|[Homework Week 7](/Week1/MAKEME.md)|
|2.|• Structure for a basic SPA (Single Page Application) <br>• [XMLHttpRequests](fundamentals/XMLHttpRequest.md) <br>• API calls|[Reading Week 8](/Week2/README.md)|[Homework Week 8](/Week2/MAKEME.md)|
|3.|• [Promises](fundamentals/promises.md)<br> • (re)writing data structures (in JSON) <br>• Async vs Sync <br>• [Event Loop (order of execution)](fundamentals/event_loop.md) |[Reading Week 9](/Week3/README.md)|[Homework Week 9](/Week3/MAKEME.md)|
|1.|• [Object Oriented Programming and Classes](../../../fundamentals/blob/master/fundamentals/oop_classes.md)<br>• [The `this` keyword](../../../fundamentals/blob/master/fundamentals/this.md) |[Reading Week 1](/Week1/README.md)|[Homework Week 1](/Week1/MAKEME.md)|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these and other links relative? If it's in another repo use the full URL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment in other pr

README.md Outdated
@@ -1,14 +1,14 @@
>Please help us improve and share your feedback! If you find better tutorials or links, please share them by opening a Pull Request.

# HackYourJavaScript
# JavaScript3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe HackYourFuture JavaScript 3 instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I like it.

@remarcmij
Copy link
Contributor

remarcmij commented Mar 13, 2018

All links seem to work fine.

One thing that I sometimes found confusing is that the prereading for a lecture is to be found in the README/MAKEME of the previous lecture (hence the need for a Week 0). Can't we just have the prereading in the README of the corresponding lecture?

@mkruijt
Copy link
Member Author

mkruijt commented Mar 13, 2018

"Can't we just have the prereading in the README of the corresponding lecture?" yes, we can do that I also have thought about removing the makeme entirely and puttting the homework and readings all in the readme. It could be that in some cases the file would become quite big.

For the content wise remarks, could you please create an issue, I rather solve one problem at a time :)

@mkruijt
Copy link
Member Author

mkruijt commented Mar 13, 2018

Oh and if i'm correct the error handeling is partly covered here: https://github.com/HackYourFuture/debugging, merging this repo with the javascript assignments is the next thing on my todo list 💃

@remarcmij
Copy link
Contributor

try & catch and new Error(...) is not covered in the debugging repo. These topics are not about debugging. They are about writing code to handle runtime errors.

@remarcmij
Copy link
Contributor

Can we finalize and merge this one, please? I would like to make some further changes as I need to teach this module to class 14.

Copy link
Contributor

@remarcmij remarcmij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to make further changes here. Let's work with relative paths for now until we find a better solution.

@mkruijt mkruijt dismissed GeorgeSapkin’s stale review March 19, 2018 08:53

Hi George, we have to work with this repo. Like Jim said, let's work with relative paths for now until we find a better solution. I'm going to merge this now

@mkruijt mkruijt merged commit 5198899 into HackYourFuture:master Mar 19, 2018
mkruijt added a commit that referenced this pull request May 27, 2018
wesam-k pushed a commit to wesam-k/JavaScript3 that referenced this pull request Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants