Resubmission of PR to remove block by Maartje #14

remarcmij · 2018-06-07T22:55:51Z

No description provided.

mkruijt

thanks @remarcmij , not sure if I already submitted this review, my internet connection is kind of bad

mkruijt · 2018-06-08T09:59:25Z

README.md

@@ -19,3 +19,5 @@ We expect you to __always__ come prepared to the class on Sunday.
 A good understanding of all the above mentioned topics. Want to check your Knowledge? Go through the [JavaScript Fundamentals README](../../../fundamentals/blob/master/README.md) and research/ ask for help (Slack!) with the concepts that are not entirely clear.

 *The HackYourFuture curriculum is subject to CC BY copyright. This means you can freely use our materials, but just make sure to give us credit for it :)*
+


thank you for adding the licence

mkruijt · 2018-06-08T10:00:55Z

Week1/MAKEME.md


-## Step 3: SPA :sweat_drops:
+_This homework is more extensive and challenging than previous homework! Please read the instructions below carefully and follow them meticulously. Start this homework as soon as you can and allow time for discussion and questions (slack!)._


maybe replace "meticulously" with "great attention to detail"

mkruijt · 2018-06-08T10:02:50Z

Week1/MAKEME.md


-This application should display information about the available [HYF repositories](https://github.com/hackyourfuture):
+This application should display information about the available [HYF GitHub repositories](https://github.com/hackyourfuture):

 - You should be able to select a repository from a list of available repositories.


maybe we can add "functionalities" or "requirements" on the top of this list?

Can you give an example of what you mean?

yes, so here you give a first indication of the functionalities of what the students should build. So maybe we can add:

functionalities we would like to see in your application:

this application....

this application...

etc

etc

It is only about the line above the list of functionalities, indicating that this should be the "end" product

Got it! Done.

mkruijt · 2018-06-08T10:05:43Z

Week1/MAKEME.md

+
+You will be working on this same application during the next three weeks. For each week you will need to create a new Git branch, as listed in the Table 1 below.
+
+| Week | Branch | Assignment |


this is great thank you

mkruijt · 2018-06-08T10:06:36Z

Week1/MAKEME.md

+
+The files that make up the application are located in the `src` folder. It contains the following files:
+
+| Filename         | Description |


great @remarcmij thank you

mkruijt · 2018-06-08T10:17:23Z

Week3/MAKEME.md


 _Deadline Monday_

-Give feedback on Step 3 of last weeks homework. Please provide the feedback in an issue.
+- Fix Requested Changes (if any) on the Pull Request.


mkruijt · 2018-06-08T10:19:12Z

Week3/MAKEME.md

+2. Make sure that your error handling code still works. See the week2 MAKEME on how to force an error response from GitHub.
+
+
+#### 2.2.2 ARIA-compliance


could you please turn 2.2.2 and 2.2.3 around? And make 2.2.2 the bonus assignment? I'm afraid that this is a lot of homework for one week and that students will not be able to finish all and will leave out 2.2.3

2.2.2 is now ES6 Classes (BONUS)
2.2.3 is now ARIA-compliance

mkruijt · 2018-06-08T10:26:03Z

README.md

@@ -9,7 +9,7 @@ Here you can find course content and homework for the JavaScript3 modules
 |----|-----|----|--------|
 |1.|• Structure for a basic SPA (Single Page Application) <br>• [XMLHttpRequests](../../../fundamentals/blob/master/fundamentals/XMLHttpRequest.md) <br>• API calls|[Reading Week 1](/Week1/README.md)|[Homework Week 1](/Week1/MAKEME.md)|
 |2.|• [Event Loop (order of execution)](../../../fundamentals/blob/master/fundamentals/event_loop.md)<br>• [Promises](../../../fundamentals/blob/master/fundamentals/promises.md)|[Reading Week 2](/Week2/README.md)|[Homework Week 2](/Week2/MAKEME.md)|
-|3.|• [try...catch](../../../fundamentals/blob/master/fundamentals/try_catch.md)<br>• [async/await](../../../fundamentals/blob/master/fundamentals/async_await.md)<br>• [Object Oriented Programming and ES6 Classes](../../../fundamentals/blob/master/fundamentals/oop_classes.md)<br>• [The `this` keyword](../../../fundamentals/blob/master/fundamentals/this.md)<br>• call, apply, bind |[Reading Week 3](/Week3/README.md)|[Homework Week 3](/Week3/MAKEME.md)|
+|3.|• [try...catch](../../../fundamentals/blob/master/fundamentals/try_catch.md)<br>• [async/await](../../../fundamentals/blob/master/fundamentals/async_await.md)<br>• [The `this` keyword](../../../fundamentals/blob/master/fundamentals/this.md)<br>• call, apply, bind<BR>• [Object Oriented Programming and ES6 Classes](../../../fundamentals/blob/master/fundamentals/oop_classes.md)|[Reading Week 3](/Week3/README.md)|[Homework Week 3](/Week3/MAKEME.md)|


<br> in small capitals

mkruijt · 2018-06-08T10:40:14Z

Week3/MAKEME.md

+2. Make sure that your error handling code still works. See the week2 MAKEME on how to force an error response from GitHub.
+
+
+#### 2.2.2 ES6 Classes (BONUS)


I prefer 2.2.3 to be bonus

I misunderstood. ARAI compliance is now BONUS instead of ES6 classes.

remarcmij · 2018-06-08T10:40:39Z

Hi Maartje, I closed the previous pull request and created a new one as I was under the assumption that you were (rightly) incommunicado and I wanted to finish this one for class 15 with Laurens.

mkruijt

Hi Jim, yes I understand, no problem. I'm super happy with the better instructions on how to hand in homework with branches, hopefully it will save us some headache. Thank you for the great work 🙏 🙋

remarcmij · 2018-06-08T10:57:31Z

Thanks Maartje for taking the time during your holiday to review. Now get back to the business of enjoying your holiday!

mkruijt · 2018-06-08T12:27:35Z

Very welcom Jim. Yes, I will 🌞

remarcmij added 4 commits May 27, 2018 10:57

preparation for homework as PR

99d49ad

updated MAKEME's

14cb668

Merge remote-tracking branch 'upstream/master'

696ad59

Removed bonus designation from ES6 classes assignment

a02af33

remarcmij requested a review from Razpudding June 7, 2018 22:56

mkruijt suggested changes Jun 8, 2018

View reviewed changes

incorporated Maartjes feedback

c1d1303

mkruijt suggested changes Jun 8, 2018

View reviewed changes

remarcmij added 2 commits June 8, 2018 12:44

Made ARIA-compliance BONUS instead of ES6 Classes

5c9c677

Clarification on the functionalities the application is to deliver

936bff1

mkruijt approved these changes Jun 8, 2018

View reviewed changes

mkruijt merged commit 2a362f8 into HackYourFuture:master Jun 8, 2018

		@@ -19,3 +19,5 @@ We expect you to __always__ come prepared to the class on Sunday.
		A good understanding of all the above mentioned topics. Want to check your Knowledge? Go through the [JavaScript Fundamentals README](../../../fundamentals/blob/master/README.md) and research/ ask for help (Slack!) with the concepts that are not entirely clear.

		The HackYourFuture curriculum is subject to CC BY copyright. This means you can freely use our materials, but just make sure to give us credit for it :)


		## Step 3: SPA :sweat_drops:
		_This homework is more extensive and challenging than previous homework! Please read the instructions below carefully and follow them meticulously. Start this homework as soon as you can and allow time for discussion and questions (slack!)._


		You will be working on this same application during the next three weeks. For each week you will need to create a new Git branch, as listed in the Table 1 below.

		\| Week \| Branch \| Assignment \|


		The files that make up the application are located in the `src` folder. It contains the following files:

		\| Filename \| Description \|

		2. Make sure that your error handling code still works. See the week2 MAKEME on how to force an error response from GitHub.


		#### 2.2.2 ARIA-compliance

		2. Make sure that your error handling code still works. See the week2 MAKEME on how to force an error response from GitHub.


		#### 2.2.2 ES6 Classes (BONUS)

Resubmission of PR to remove block by Maartje #14

Resubmission of PR to remove block by Maartje #14

Uh oh!

Conversation

remarcmij commented Jun 7, 2018

Uh oh!

mkruijt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

remarcmij commented Jun 8, 2018

Uh oh!

mkruijt left a comment

Choose a reason for hiding this comment

Uh oh!

remarcmij commented Jun 8, 2018

Uh oh!

mkruijt commented Jun 8, 2018

Uh oh!

Uh oh!