Week1 Hammed HW #24
Closed
Week1 Hammed HW #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongwartz
reviewed
Jun 17, 2017
| // /state | ||
| // response: the current state in a html format | ||
| // when the server starts, this should return "10" | ||
| //in this case we just show the curent state value |
There was a problem hiding this comment.
I love how you put the spec right in the comments. People refer to this as having the documentation "close to the code". It's a great habit to get into.
| break; | ||
| // This should set the state back to 10 | ||
| // I didnt want to start with error so I did the first step as reset and show the state. | ||
| case '/reset': |
There was a problem hiding this comment.
What will happen here if the /reset case is hit? What lines of code then get executed?
| } | ||
| // this function take the state value and make some html tages to show it. | ||
| // I did some extra button to make the request url faster. | ||
| function showState(state){ |
There was a problem hiding this comment.
I like how you pass in the state value as a parameter. This makes it slightly easier to reuse some of this code if the structure were to change.
There was a problem hiding this comment.
Also, is the response object defined in this scope? Why or why not?
| // response: the current state in a html format | ||
| // when the server starts, this should return "10" | ||
| //in this case we just show the curent state value | ||
| case '/state': |
There was a problem hiding this comment.
Your case statements should be indented further than the switch declaration.
| console.log(data); | ||
| }); | ||
|
|
||
| fs.readFile('./data1.json', 'utf-8', function(err, data) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my homework is index.js the other files are just exercise.