Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Symfony 4.2: support translation file suffix "+intl-icu" #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gharlan opened this issue Nov 8, 2018 · 8 comments
Closed

Symfony 4.2: support translation file suffix "+intl-icu" #1251

gharlan opened this issue Nov 8, 2018 · 8 comments
Labels

Comments

@gharlan
Copy link

gharlan commented Nov 8, 2018

symfony/symfony#28952

At the moment all messages are marked as missing in phpstorm.

@gharlan
Copy link
Author

gharlan commented Jan 9, 2019

Also the message domains should be suggested without the suffix:

screenshot 2019-01-09 14 25 51

@digilist
Copy link
Contributor

digilist commented Jan 9, 2019

I did it this way, because in Symfony this is a valid domain and you can use it.

@digilist
Copy link
Contributor

digilist commented Jan 9, 2019

Ah never mind, you mean that it should be shown without the suffix as well. Will fix it :)

@digilist
Copy link
Contributor

digilist commented Jan 9, 2019

Hmm, no wait 😄 Did you test the PR that I provided or is this unrelated? Otherwise this is fixed with my PR.

@gharlan
Copy link
Author

gharlan commented Jan 9, 2019

Did you test the PR that I provided or is this unrelated?

It's unrelated, I use the current release.

Otherwise this is fixed with my PR.

Cool! And thanks for your pr! ❤️

@digilist
Copy link
Contributor

It's merged, this can be closed now ☺️

@Haehnchen
Copy link
Owner

its released, feedback is welcome ;)

@gharlan
Copy link
Author

gharlan commented Jan 16, 2019

Made a quick test, and it seems to work very well! Thanks a lot! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants