Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Completion for YAML tags, keywords and PHP constants #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

[WIP] Completion for YAML tags, keywords and PHP constants #1336

wants to merge 19 commits into from

Conversation

King2500
Copy link
Contributor

@King2500 King2500 commented Jul 7, 2019

  • Adds completion for generic YAML tags like !php/const, !!str etc
  • Adds completion for specific YAML tags in services.yaml like !tagged etc
  • Adds completion and goto definition for PHP constants (class and global) after !php/const <caret>
  • Adds completion for YAML keywords like true, false, null etc

Todo: describe more details

It's still work in progress:
I have to add some tests

Screenshots:

image

image

King2500 and others added 14 commits May 25, 2019 23:04
@King2500
Add completion for Yaml tags (!php/const etc)
5ffda38
@King2500
Add completion for PHP constants after !php/const in YAML files
494065e
@King2500
Add completion for PHP constants after !php/const in YAML files [WIP]
ba051ad
@King2500
Add completion for PHP constants after !php/const in YAML files [WIP]
96b9728
@King2500
Add completion for YAML keywords (true, false, null, etc)
c052982
@King2500
YAML completions: fix PhpConstPattern
00dd1bd
@King2500
Add completion for PHP constants after !php/const: (Sf 3.2/3.3)
ba27c9c
@King2500
Add completion for Service Yaml tags (!service, !iterator, etc)
78700d8
@King2500
AutoPopup for "!" char inside YAML service arguments
3e8e594
@King2500
Complete YAML Service tags for current Symfony version when full-stac…
401dd5b 
…k framework is not installed
@King2500
Fix completion for YAML tags and keywords inside key
09a43f6
@King2500
Make YAML tag completion compatible with upcoming 2019.2 version
f343d42
@King2500
Make YAML keywords completion compatible with JSON schemas and prepar…
78101bc 
…e for 2019.2
@King2500
Make YAML keywords completion compatible with JSON schemas and prepar…
ceab0df 
…e for 2019.2
@Haehnchen
Copy link
Owner

can i support here somehow? there some commit in the code. also about 2019.2.
currently there no blocker to higher the since build, this allows to use java11

@King2500
Copy link
Contributor Author

It needs some testcases where completion should come up and where not.

@King2500
Copy link
Contributor Author

@Haehnchen Do you know why tests fail with jdk8 ?
Expected feature release number in range of 9 to 14, but got: 8

Is Travis configured correctly?

@King2500
Copy link
Contributor Author

King2500 commented Aug 1, 2019

Notes to myself:
Todos:

@Haehnchen
Copy link
Owner

moved in all via: #1364

@King2500 King2500 marked this pull request as ready for review September 1, 2019 13:44
@King2500
Copy link
Contributor Author

King2500 commented Sep 1, 2019

👍

should i just close this?

@Haehnchen
Copy link
Owner

yes closing this ;)

@Haehnchen Haehnchen closed this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@King2500 @Haehnchen