installer-setup WS-A: delete stale packaging/avahi/hal0.service#1123
Merged
Conversation
packaging/avahi/hal0.service advertised Caddy on 443/80 with an --auth=basic header, but the installer ships no Caddy, sets no --auth flag, and has zero references to this file anywhere in install.sh or installer/lib. If it were ever actually dropped at /etc/avahi/services/hal0.service it would advertise ports nothing is listening on. It's not part of the current mDNS story (see the addon-service advertiser in hal0.services.mdns), so remove it and the stale doc-comment in mdns.py that pointed at it. Closes #1096 Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packaging/avahi/hal0.service, a stale avahi mDNS unit that advertised Caddy on ports 443/80 with an--auth=basicheader — but the installer ships no Caddy, sets no--authflag, and had zero references to this file anywhere ininstaller/install.shorinstaller/lib/. If it were ever actually dropped at/etc/avahi/services/hal0.service, it would advertise ports nothing listens on.src/hal0/services/mdns.pythat pointed atpackaging/avahi/hal0.serviceby path, since that file no longer exists. The runtime behavior inmdns.py(checking whether some/etc/avahi/services/hal0.servicefile exists for thebase_advertisedstatus flag, and never touching that file when writing/pruning addon service files) is unrelated to this packaging source file and is left untouched — that logic is still correct regardless of what (if anything) drops the base file.References cleaned up
installer/install.sh,installer/lib/*,installer/manifests/*: no references found (verified viagit grep), so no installer/manifest changes were needed beyond the doc-comment above.Verification checklist
git grep -n 'packaging/avahi/hal0.service'→ no matches (clean delete)uv run ruff format src tests→ 634 files already formatteduv run ruff check src tests→ All checks passed!uv run ruff format --check src tests→ 634 files already formatteduv run pytest tests/ -q --ignore=tests/e2e→ 14 failed, 4614 passed, 8 skipped, 1 error (all 14 failures are pre-existing and unrelated to this change:test_hermes_state_render,test_hermes_wrapper,test_comfyui_phase4,test_config_urls,test_models_preview,test_settings_models_store,test_agent_install_hermes,test_agent_shim(hermes web-dist env),test_pve(proxmox host detection),test_container_spec_dispatch. None touch installer/packaging/avahi/mdns code paths.)Closes #1096
🤖 Generated with Claude Code