-
Notifications
You must be signed in to change notification settings - Fork 65
feat: improve toolbar responsiveness and UI layout #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add responsive toolbar with container query (hide elements at ≤340px) - Remove unnecessary padding for better message alignment - Improve assistant message dot visibility with adaptive color - Update .gitignore to exclude .cursor directory
Reviewer's GuideThis PR enhances UI responsiveness and layout by implementing a toolbar container query with data-responsive attributes for narrow screens, removes excess padding in tool message wrappers for cleaner alignment, adjusts the assistant message dot to use adaptive coloring for better contrast, and updates .gitignore to exclude the .cursor directory. Class diagram for updated ButtonArea and TokenIndicator componentsclassDiagram
class ButtonArea {
+handleThinkingToggle()
+data-responsive="hide-small" (on action buttons)
}
class TokenIndicator {
+formattedPercentage
+data-responsive="hide-small" (on progress-text span)
}
Class diagram for updated ToolMessageWrapper and AssistantMessage componentsclassDiagram
class ToolMessageWrapper {
-padding: 0px 8px
+padding: 0px
}
class AssistantMessage {
-color: var(--vscode-input-border) (dot)
+color: color-mix(in srgb, var(--vscode-foreground) 60%, transparent) (dot)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider scoping the global body reset to the webview container only, as resetting
<body>might unintentionally override host styles or future layout rules. - Since CSS container queries aren’t supported in all Electron/VSCode versions, add a fallback or feature-detect strategy to avoid layout breakage in unsupported environments.
- Using
!importantfor hiding toolbar elements could lead to specificity wars; try a more specific selector or leverage utility classes instead.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider scoping the global body reset to the webview container only, as resetting `<body>` might unintentionally override host styles or future layout rules.
- Since CSS container queries aren’t supported in all Electron/VSCode versions, add a fallback or feature-detect strategy to avoid layout breakage in unsupported environments.
- Using `!important` for hiding toolbar elements could lead to specificity wars; try a more specific selector or leverage utility classes instead.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Improve toolbar responsiveness with container queries, refine layout spacing and assistant message dot contrast, and update .gitignore rules
New Features:
Enhancements:
Chores: