fix: Close tty first in ptytest cleanup (coder#5252)

mafredri · web-flow · commit 81c39487924d · 2022-12-02T12:32:50.000Z
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -107,6 +107,7 @@
     "slogtest",
     "sourcemapped",
     "Srcs",
+    "stdbuf",
     "stretchr",
     "STTY",
     "stuntest",
diff --git a/pty/ptytest/ptytest.go b/pty/ptytest/ptytest.go
@@ -72,8 +72,13 @@ func create(t *testing.T, ptty pty.PTY, name string) *PTY {
 		ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
 		defer cancel()
 
-		_ = out.Close()
-		_ = ptty.Close()
+		// Close pty only so that the copy goroutine can consume the
+		// remainder of it's buffer and then exit.
+		err := ptty.Close()
+		// Pty may already be closed, so don't fail the test, but log
+		// the error in case it's significant.
+		logf(t, name, "closed pty: %v", err)
+
 		select {
 		case <-ctx.Done():
 			fatalf(t, name, "cleanup", "copy did not close in time")
