Add search_element and rename find_element! to find_element. #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@HashNuke What do you think? |
Owner
|
@tuvistavie This looks good ~! So to summarize, these are selectors:
These are searchers:
👍 Thank you very much ~! |
Owner
|
@tuvistavie IMHO our basics are pretty much set. We can go for a 1.0 version. Feel free to make a release when you see fit. |
Collaborator
Author
|
@HashNuke Thank you for the feedback! I also think we are good to go, so I am going to release 1.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
search_elementand restorefind_elementto its previous behavior of raising on any error.This way, there should be no backward incompatibility here while we can still easily check for errors.