Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use more memory efficient method of storing numbers#6

Open
KorvinSzanto wants to merge 2 commits into
Herzult:masterfrom
KorvinSzanto:master
Open

Use more memory efficient method of storing numbers#6
KorvinSzanto wants to merge 2 commits into
Herzult:masterfrom
KorvinSzanto:master

Conversation

@KorvinSzanto
Copy link
Copy Markdown

SplObjectStorage is better suited for what we're trying to do in NumberCollection.

@mikeytag
Copy link
Copy Markdown

mikeytag commented Mar 8, 2013

Agreed. Anything that smells of proceduralness should be removed immediately. I'm looking at you arrays.

@ultimape
Copy link
Copy Markdown

Why don't we store the values within a Java Bean. Then we can persist them to a database and get all sorts of delicious metrics.

Also, is this threadsafe?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave a break line before return

@an-empty-string
Copy link
Copy Markdown

Why not just use a hashing algorithm to store the numbers in a map, keyed by string index?

@gquemener
Copy link
Copy Markdown

I would recommend a hash key generator then

@KorvinSzanto
Copy link
Copy Markdown
Author

Its becoming clear that we need to rearchitect the way we handle number
collections.
On May 20, 2014 8:49 AM, "Gildas Quéméner" [email protected] wrote:

I would recommend a hash key generator then


Reply to this email directly or view it on GitHubhttps://github.com//pull/6#issuecomment-43644265
.

@an-empty-string
Copy link
Copy Markdown

I'm thinking, that instead of a hash generator, perhaps we should architect our own NumberLinkedListNode class, and then use a doubly-linked circular linked list. This maximizes the efficiency of number operations while allowing us to effectively use the object-oriented paradigm. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants