fix: Enable godmode for dev-center to open worker files in editor #2224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes HeyPuter#2218 The DEV Center was unable to open worker files in the text editor because it lacked godmode permissions. The file_paths parameter in puter.ui.launchApp requires the calling app to have godmode=1 in order to work. Changes: - Added database migration 0044_dev-center-godmode.sql to set godmode=1 for the dev-center app (uid: app-0b37f054-07d4-4627-8765-11bd23e889d4) - Updated SqliteDatabaseAccessService.js to include the new migration This allows DEV Center to successfully pass file paths when launching the editor app, fixing the issue where clicking on a worker file path resulted in an empty editor window.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Enable godmode for dev-center to open worker files in editor
Fixes #2218
Problem
The DEV Center was unable to open worker files in the text editor. When users clicked on a worker's file path in the DEV Center, the editor would open with an empty file instead of displaying the worker's code.
Root Cause
The issue was identified in the file opening flow:
workers.jsusesputer.ui.launchApp()with thefile_pathsparameter to open worker files in the editorExecService.jsrequires the calling app to havegodmode=1permissions to use thefile_pathsparametergodmode=0in the databaseWithout godmode permissions, the
file_pathsparameter was silently ignored, causing the editor to launch without any file loaded.Solution
0044_dev-center-godmode.sqlto setgodmode=1for the dev-center appSqliteDatabaseAccessService.jsto include the new migration in the migration sequenceChanges
src/backend/src/services/database/sqlite_setup/0044_dev-center-godmode.sql(new file)src/backend/src/services/database/SqliteDatabaseAccessService.js(modified)Testing
After this change: