refactor(tui): share hard-wrap helper across renderers#1671
Open
Aitensa wants to merge 1 commit into
Open
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/tui/src/tui/ui_text.rsmarkdown_render,diff_render, andpagerWhy
A follow-up to the merged CJK wrapping fix in #1622. This addresses review feedback about duplicated hard-wrap helpers across TUI renderers without broadening the original bug-fix scope.
Validation
cargo fmt --all --checkcargo test -p deepseek-tui --bin deepseek-tui wrap_text_breaks_overlong_cjk_runs --lockedcargo test -p deepseek-tui --bin deepseek-tui render_diff_prepends_summary_and_gutter_markers --lockedcargo test -p deepseek-tui --bin deepseek-tui footer_hint_is_rendered_in_buffer --locked