Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(tui): add full-screen thinking stream#1755

Open
LING71671 wants to merge 2 commits into
Hmbown:mainfrom
LING71671:feat/full-thinking-stream
Open

feat(tui): add full-screen thinking stream#1755
LING71671 wants to merge 2 commits into
Hmbown:mainfrom
LING71671:feat/full-thinking-stream

Conversation

@LING71671
Copy link
Copy Markdown

Summary

Fixes #1750.

This adds a full-terminal live thinking stream so long reasoning output can be monitored as it arrives without being squeezed into the compact transcript pane.

What changed

  • Added a /thinking slash command, with /think as a short alias, that opens a thinking-only live overlay.
  • Extended the existing LiveTranscriptOverlay with a ThinkingOnly mode that:
    • refreshes from the active transcript snapshot every frame, so streaming reasoning continues updating while the overlay is open;
    • filters the overlay to HistoryCell::Thinking entries only;
    • renders thinking cells with full-detail transcript rendering instead of compact summaries;
    • keeps the existing sticky-tail controls so the user can either follow the newest reasoning or scroll away and resume tailing with End/G.
  • Updated Ctrl+O Activity Detail behavior for in-flight thinking: when the selected/current activity is still streaming, it opens the live thinking stream; finalized thinking still opens the existing reasoning timeline pager.
  • Added localized command descriptions for the shipped locales.

Verification

  • cargo fmt --all -- --check
  • cargo test -p deepseek-tui live_transcript --all-features
  • cargo test -p deepseek-tui execute_thinking_opens_live_reasoning_stream --all-features
  • cargo test -p deepseek-tui activity_detail_opens_live_thinking_stream_for_streaming_thinking --all-features
  • cargo test -p deepseek-tui command_registry_has_unique_names_and_aliases --all-features
  • cargo test -p deepseek-tui localization --all-features
  • cargo clippy -p deepseek-tui --all-targets --all-features

Note: clippy still reports existing warnings in schema_migration.rs and existing needless_return warnings in ui.rs; no new blocking warnings were introduced by this change.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a "thinking stream" feature to the TUI, enabling a live, full-terminal overlay dedicated to reasoning steps. Key changes include the addition of the /thinking command (and /think alias), a new ThinkingOnly mode for the live transcript overlay, and integration into the UI to trigger this view when selecting active reasoning cells. Feedback suggests refactoring duplicated rendering logic in live_transcript.rs to improve maintainability, localizing hardcoded status and label strings to match the project's internationalization standards, and optimizing the inspection of the view stack to avoid inefficient pop and push operations.

Comment thread crates/tui/src/tui/live_transcript.rs
Comment thread crates/tui/src/tui/live_transcript.rs
Comment thread crates/tui/src/tui/ui.rs Outdated
Comment thread crates/tui/src/tui/ui.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

show the full thinking stream as it arrives

1 participant