-
Notifications
You must be signed in to change notification settings - Fork 15
Add if-else statement and ternary operator #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove
.eslintrc.yml
from rull-request because of merge conflict - Use eslint before comit
- After that you need to rebase with master, I'll help
JavaScript/5-if-else.js
Outdated
@@ -0,0 +1,45 @@ | |||
'use strict'; | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use single empty line to separate logical blocks
JavaScript/5-if-else.js
Outdated
} | ||
|
||
if (condition2) | ||
console.log('5 > 3'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use {}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or remove \n to have single line condition
} | ||
// Good syntax | ||
condition2 ? console.log('5 > 3') : console.log(false); | ||
// Good syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove lines and file .gitignore
, everything else is ok
const condition2 = 5 > 3; // Boolean true | ||
const name = 'Ryu'; // String | ||
|
||
// Good syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove line
if (condition1) { | ||
console.log('5 < 3'); | ||
} | ||
// Good syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove line
No description provided.