-
Notifications
You must be signed in to change notification settings - Fork 155
WIP: Simplify implicit solver implementation #1661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
boyceg
wants to merge
37
commits into
master
Choose a base branch
from
boyceg/implicit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will break this up into smaller PRs but wanted to put up something for discussion. |
579d298
to
fcf2e80
Compare
…e time step size used
8af03bb
to
dc12668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and simplifies the implementation of implicit solvers of the form:
with
as well as the "direct forcing" form:
IBAMR Pull Request Checklist
Fixes #12345
to closethe issue automatically if we are fixing the problem.
changelog entry been added?
up appropriately for restarts? If so, ensure that the restart version
number is incremented.
or tests should be added. New tests should run quickly (less than a minute
in release mode). If possible, an older test should gain a new option so
that we do not need to compile more test executables.
GitHub for the pull request?