Thanks to visit codestin.com
Credit goes to github.com

Skip to content

support multiline text input in test tool panel #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

support multiline text input in test tool panel #650

merged 1 commit into from
Aug 1, 2025

Conversation

kevalmahajan
Copy link
Member

@kevalmahajan kevalmahajan commented Aug 1, 2025 •
edited
Loading

🐛 Bug-fix PR

📌 Summary

The test tool panel did not support multiline input. As a result, cases requiring multiline input such as code with newlines/indentations were passed as a single line, causing the tool to fail.

🔁 Reproduction Steps

  1. Pass code with more than one line to a tool in the test tool panel.
  2. Observe the tool failure due to incorrect formatting.

🐞 Root Cause

The test tool panel lacked support for multiline or properly formatted input, resulting in broken inputs for formats that rely on structure, such as Python or Mermaid.

💡 Fix Description

Enabled support for multiline input in the test tool panel ensuring that text blocks with indentation, new lines are passed and interpreted correctly.

Example Input for Mermaid tool:

graph TD
  A[Start] --> B{Is it working?}
  B -- Yes --> C[Great!]
  B -- No --> D[Check the config]
  D --> B

Earlier Behaviour:
The input passed to the tool would be :

graph TD  A[Start] --> B{Is it working?}  B -- Yes --> C[Great!]  B -- No --> D[Check the config] D --> B

Causing tool call failure because of invalid code.

Current behaviour:
The string entered in the text box is passed exactly with new lines:

graph TD
  A[Start] --> B{Is it working?}
  B -- Yes --> C[Great!]
  B -- No --> D[Check the config]
  D --> B

🧪 Verification

Check Command Status
Lint suite make lint
Unit tests make test
Coverage ≥ 90 % make coverage
Manual regression no longer fails steps / screenshots

📐 MCP Compliance (if relevant)

  • Matches current MCP spec
  • No breaking change to MCP clients

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • No secrets/credentials committed

crivetimihai
crivetimihai approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@crivetimihai crivetimihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary: support multiline text input in test tool panel

  • Purpose: This PR fixes a bug where the test tool panel did not support multiline input. Previously, when users needed to input code with newlines or indentation (e.g., Python or Mermaid diagrams), the input was flattened into a single line, which broke the tool's functionality.

  • What changed:

    • The PR modifies the admin.js UI logic to use a <textarea> for text input fields, allowing for multiline input.
    • The input is now passed to tools exactly as entered, preserving newlines and formatting. Boolean and number fields are handled as before.

  • Example: Previously, Mermaid diagrams were passed as one long line, causing failures. Now, multiline and indented text is preserved and processed correctly.

  • Verification: The PR lists linting, unit test, and regression test checks to verify the fix.

  • Impact: This improves usability for tools requiring formatted/multiline input and resolves issues with tools that failed due to broken formatting.

No breaking changes are introduced. The change is limited to the test tool panel's input handling in the admin UI.

Passed make lint-web doctest test

@crivetimihai crivetimihai merged commit 182cde8 into main Aug 1, 2025
37 checks passed
@crivetimihai crivetimihai deleted the multiline_input_testtool branch August 1, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crivetimihai crivetimihai crivetimihai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevalmahajan @crivetimihai