Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Bug in pdl_schema_error_analyzer that raises exception during analysis #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

fix: Bug in pdl_schema_error_analyzer that raises exception during analysis #851

merged 1 commit into from
Mar 28, 2025

Conversation

vite-falcon
Copy link
Contributor

Summary

When the PDL doesn't match the schema, the error analysis fails as it attempts to retrieve the field names without verifying that "properties" key exists in ref_type.

This change returns an empty dict if properties key doesn't exist in ref_type to allow the error analysis to complete successfully.

Fixes: #850

Sample PDL

description: Vision model example
text:
- model: openai/gpt-4o-mini
  input:
    array:
    - role: user
      content:
      - type: text
        text: "What's in this image?"
      - type: image_url
        image_url:
          url: "https://upload.wikimedia.org/wikipedia/commons/thumb/d/dd/Gfp-wisconsin-madison-the-nature-boardwalk.jpg/2560px-Gfp-wisconsin-madison-the-nature-boardwalk.jpg"
  parameters:
    max_tokens: 500
    temperature: 0.7

Expected Error

['from-string:8 - [{\'type\': \'text\', \'text\': "What\'s in this image?"}, {\'type\': \'image_url\', \'image_url\': {\'url\': \'https://upload.wikimedia.org/wikipedia/commons/thumb/d/dd/Gfp-wisconsin-madison-the-nature-boardwalk.jpg/2560px-Gfp-wisconsin-madison-the-nature-boardwalk.jpg\'}}] should not be a list'].

Actual Error

'properties' 

File "[...]\noxfile.py", line 85, in pdl_lint
    PdlExecutor.validate_pdl_file(pdl_file)
  File "[...]\pdl\executor.py", line 192, in validate_pdl_file
    PdlExecutor.validate_pdl_string(pdl_file.read_text(encoding="utf-8"))
  File "[...]\pdl\executor.py", line 185, in validate_pdl_string
    _, _ = parse_pdl_str(pdl_string, file_name=file_name)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[...]\.venv\Lib\site-packages\pdl\pdl_parser.py", line 39, in parse_str
    errors = analyze_errors(defs, defs["Program"], prog_yaml, loc)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[...]\.venv\Lib\site-packages\pdl\pdl_schema_error_analyzer.py", line 188, in analyze_errors
    ret += analyze_errors(defs, match_ref, data, loc)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[...]\.venv\Lib\site-packages\pdl\pdl_schema_error_analyzer.py", line 117, in analyze_errors
    ret += analyze_errors(
           ^^^^^^^^^^^^^^^
  File "[...]\.venv\Lib\site-packages\pdl\pdl_schema_error_analyzer.py", line 157, in analyze_errors
    ret += analyze_errors(defs, found, data, loc)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[...]\.venv\Lib\site-packages\pdl\pdl_schema_error_analyzer.py", line 91, in analyze_errors
    ret += analyze_errors(defs, schema["items"], item, newloc)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[...]\.venv\Lib\site-packages\pdl\pdl_schema_error_analyzer.py", line 188, in analyze_errors
    ret += analyze_errors(defs, match_ref, data, loc)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[...]\.venv\Lib\site-packages\pdl\pdl_schema_error_analyzer.py", line 117, in analyze_errors
    ret += analyze_errors(
           ^^^^^^^^^^^^^^^
  File "[...]\.venv\Lib\site-packages\pdl\pdl_schema_error_analyzer.py", line 167, in analyze_errors
    field_matches = match(item, data)
                    ^^^^^^^^^^^^^^^^^
  File "[...]\.venv\Lib\site-packages\pdl\pdl_schema_error_analyzer.py", line 51, in match
    all_fields = ref_type["properties"].keys()
                 ~~~~~~~~^^^^^^^^^^^^^^

NOTE: I attempted to run pytest tests and pre-commit run --all-files, but they fail since I don't have the granite models. The same tests fails without my changes as well.

@vite-falcon
fix: Bug in pdl_schema_error_analyzer that raises exception during an…
748ba9e 
…alysis

When the PDL doesn't match the schema, the error analysis fails as it attempts to retrieve the field names without verifying that `"properties"` key exists in `ref_type`.

This change returns an empty `dict` if `properties` key doesn't exist in `ref_type` to allow the error analysis to complete successfully.

Signed-off-by: Abi Ullattil <[email protected]>
@starpit
Copy link
Member

starpit commented Mar 28, 2025

nice catch!

@vazirim
Copy link
Member

vazirim commented Mar 28, 2025

Thanks for the PR!

@vazirim vazirim merged commit 4d1e9dd into IBM:main Mar 28, 2025
6 checks passed
@vite-falcon vite-falcon deleted the bug/vite-falcon/pdl_schema_error_analyzer-20250327 branch March 28, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error analysis fails when PDL doesn't match schema
3 participants
@vite-falcon @starpit @vazirim