Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jgchn
Copy link
Collaborator

@jgchn jgchn commented Mar 29, 2025

Fixes #436

  • Remove non-determinism in example runs, including removing all files that are greater than *.0.result. Since Bug fixes for setting default parameters #838 is merged, there should only be one result file from now on
  • Allow GH Actions to commit new results to push and pull request events. In particular, those results will be stored in the file: <program-name>.ollama_ghactions.result. For locally generated results, developers should still use tests/results/examples/<program-name>.0.result. GH Actions will only generate the new file if there is variation from the expected output that is generated locally
  • Removed several examples from TO_SKIP. The ones that remain include those that require set up dependencies like downloading a dataset (cldk, gsm8), building a new model (demo-halluncination), RAG examples, structure-decoding, granite-io examples, and UI examples
  • See successful run at https://github.com/jgchn/prompt-declaration-language/actions/runs/14149599984
  • See this run which committed new files to push event. Check out the step Update example result files

jgchn and others added 14 commits March 29, 2025 13:40
Signed-off-by: Jing Chen <[email protected]>
Signed-off-by: Jing Chen <[email protected]>
Signed-off-by: Jing Chen <[email protected]>
Signed-off-by: Jing Chen <[email protected]>
Signed-off-by: Jing Chen <[email protected]>
Signed-off-by: Jing Chen <[email protected]>
Signed-off-by: Jing Chen <[email protected]>
Signed-off-by: Jing Chen <[email protected]>
Signed-off-by: Jing Chen <[email protected]>
Signed-off-by: Jing Chen <[email protected]>
Signed-off-by: Jing Chen <[email protected]>
@jgchn jgchn marked this pull request as ready for review March 29, 2025 23:10
@jgchn jgchn requested a review from vazirim March 29, 2025 23:10
Copy link
Member

@vazirim vazirim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgchn jgchn merged commit 2e660ef into IBM:main Mar 31, 2025
6 checks passed
@jgchn jgchn deleted the gh-fixes branch March 31, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tests/test_examples_run
2 participants