Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: use anonymous class instead of lambda #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2023
Merged

refactor: use anonymous class instead of lambda #1016

merged 1 commit into from
Sep 5, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Sep 3, 2023

Description of the change

Removed the use of Java 8 lambda functions in Android that was added in #1012 and replaced it with new Runnable since it breaks apps running on older versions of Java and React Native.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-12977

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Sep 3, 2023
@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
JavaScript 96.5% ✅
Android 49.6% ✅
iOS 38.9% ✅

Generated by 🚫 dangerJS against 0d56c3d

abdelhamid-f-nasser
abdelhamid-f-nasser approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for covering this 🙏🏼. I'll make sure to use anon classes as closure breaks with old java versions.

Reference: We can't have lambdas anywhere in our Java codebase (except in tests) since it'd break apps on older versions of Java.

@a7medev a7medev merged commit f59f2b1 into dev Sep 5, 2023
@a7medev a7medev deleted the fix/remove-java-lambda branch September 5, 2023 07:59
HeshamMegid pushed a commit that referenced this pull request Sep 17, 2023
@a7medev @HeshamMegid
refactor: use anonymous class instead of lambda (#1016)
8f8afb0 
Jira ID: MOB-12977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdelhamid-f-nasser abdelhamid-f-nasser abdelhamid-f-nasser approved these changes

@asamiz asamiz Awaiting requested review from asamiz

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @InstabugCI @abdelhamid-f-nasser