Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: support react native buttons label extraction in user steps #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 10, 2024
Merged

feat: support react native buttons label extraction in user steps #1109

merged 11 commits into from
Feb 10, 2024

Conversation

abdelhamid-f-nasser
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser commented Jan 28, 2024 •
edited
Loading

Description of the change

Support Capturing the label of buttons for repro-steps via adding custom implementation for the Touched View Extractor.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID:

  • IBGCRASH-21078
  • IBGCRASH-21213

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the feat/support-user-steps branch 2 times, most recently from 6a576c7 to 1a03fd4 Compare January 28, 2024 15:35
@abdelhamid-f-nasser abdelhamid-f-nasser mentioned this pull request Jan 28, 2024
Merged
7 tasks
a7medev
a7medev requested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @abdelhamid-f-nasser! 👏🏼

Please check the comments added. Let's also make sure to use ReactViewGroup and ReactTextView instead of ViewGroup and TextView when appropriate.

@abdelhamid-f-nasser abdelhamid-f-nasser added the pending-android Waiting for Android release label Jan 31, 2024
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the feat/support-user-steps branch 2 times, most recently from 9b93170 to b365a44 Compare February 1, 2024 15:37
@abdelhamid-f-nasser
Copy link
Contributor Author

I've pushed changes to implement the PrivateViews label extraction, please check them @a7medev 🙏 .

@a7medev a7medev self-requested a review February 5, 2024 14:34
@abdelhamid-f-nasser
feat(android): support repro-steps for button
bba3569 
Support extracting the label of the button in repro-steps via TouchedViewExtractor
@abdelhamid-f-nasser
feat(example): add repro-steps button samples
ae914ab 
Added buttons for testing purposes.
@abdelhamid-f-nasser
feat: Support masking in example components
59933de
@abdelhamid-f-nasser
chore(example): resolve review comments
2998e5f 
1. Remove redundant View component
2. Add missing textInputRef applying masking to it.
3. Adjust onPress messages for buttons
4. Rename `Add private views` to `Mask All Views`
5. Move refs declaration to the beginning of the component
@abdelhamid-f-nasser
chore(android): resolve review comments
c044bf4 
1. Document `getShouldDependOnNative`
2. Change all references of Native Views to React Views (TextView and ViewGroup -> ReactTextView and ReactViewGroup)
3. Rename `iteratorIndex` to  `depth`
4. Refactor the limit to a constant `depthTraversalLimit`
5. Start the loop with 1 and end at `depthTraversalLimit`
6. Add comment describing why we return null in the `extract` method
@abdelhamid-f-nasser
fix(android): handle private view label extraction
2ccb73a 
Jira ID: [IBGCRASH-21213]
@abdelhamid-f-nasser
fix(android): adjust multi label button string
81f0913 
Change the `A` to lowercase to become `a button` instead of `A button`

Jira ID: [IBGCRASH-21213]
@abdelhamid-f-nasser
chore(android): format code docs
f11d8e0
@abdelhamid-f-nasser
refactor(example): improve four tier button
aa65b2a 
Add one more Tier between the 1st Tier Text and the 4th tier text (as you click on the text itself, so there has to be enough tiers between them).
@mnoseir
Copy link

mnoseir commented Feb 10, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.2% ✅
Android 47.2% ✅
iOS 41.3% ✅

Generated by 🚫 dangerJS against 479d722

@abdelhamid-f-nasser abdelhamid-f-nasser merged commit 136e215 into dev Feb 10, 2024
@abdelhamid-f-nasser abdelhamid-f-nasser deleted the feat/support-user-steps branch February 10, 2024 05:23
HeshamMegid pushed a commit that referenced this pull request Feb 10, 2024
@abdelhamid-f-nasser @HeshamMegid
feat: support react native buttons label extraction in user steps (#1109
1e36d58 
)

Jira ID:
- IBGCRASH-21078
- IBGCRASH-21213
ahmedAlaaInstabug pushed a commit that referenced this pull request Feb 20, 2024
@abdelhamid-f-nasser @ahmedAlaaInstabug
feat: support react native buttons label extraction in user steps (#1109
09d08fd 
)

Jira ID:
- IBGCRASH-21078
- IBGCRASH-21213
@abdelhamid-f-nasser abdelhamid-f-nasser self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev requested changes

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

Assignees

@abdelhamid-f-nasser abdelhamid-f-nasser

Labels
pending-android Waiting for Android release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abdelhamid-f-nasser @mnoseir @a7medev @ahmedAlaaInstabug